Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: syzygy/refinery/symbols/dia_symbol_provider.h

Issue 1475083002: [Refinery] Introduce TypePropagatorAnalyzer - pointer types. (Closed) Base URL: https://github.com/google/syzygy.git@master
Patch Set: Final nit Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « syzygy/refinery/refinery.gyp ('k') | syzygy/refinery/symbols/symbol_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: syzygy/refinery/symbols/dia_symbol_provider.h
diff --git a/syzygy/refinery/symbols/dia_symbol_provider.h b/syzygy/refinery/symbols/dia_symbol_provider.h
index cf680320e214c2998f4247ed737a2541aa8b9794..89f9e5a5bd4c7f4f989e7b845fa7659da4d6cb4e 100644
--- a/syzygy/refinery/symbols/dia_symbol_provider.h
+++ b/syzygy/refinery/symbols/dia_symbol_provider.h
@@ -33,6 +33,9 @@ class ProcessState;
// The DiaSymbolProvider provides symbol information via the DIA interfaces.
// @note It is *not* safe to interleave access to a session in the context of
// different process states, as the session's load address may be different.
+// TODO(manzagop): replace the functions that take in a process state by
+// functions that take in a signature. Symbol providers should not need to know
+// about the process state.
class DiaSymbolProvider : public base::RefCounted<DiaSymbolProvider> {
public:
DiaSymbolProvider();
« no previous file with comments | « syzygy/refinery/refinery.gyp ('k') | syzygy/refinery/symbols/symbol_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698