Remove unnecessary ui::CompositorTestSupport

Remove unnecessary ui::CompositorTestSupport

The ui::CompositorTestSupport class existed to initialize WebKit since
ui::Compositor depends on cc which used to depend on WebKit being initialized
to function properly.  cc no longer has this requirement, so this class is
unnecessary.

R=piman, sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202787

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203042

[piman, 2013-05-11 01:59:49]

LGTM. Last time I tried it broke, but I think it was because of the shared
context which should be solved now.

[commit-bot: I haz the power, 2013-05-11 21:42:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14744016/4001

[commit-bot: I haz the power, 2013-05-11 21:42:26]

Failed to apply patch for chrome/test/base/view_event_test_base.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/test/base/view_event_test_base.cc
  Hunk #1 FAILED at 13.
  Hunk #2 succeeded at 100 (offset -2 lines).
  Hunk #3 succeeded at 156 (offset -6 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/test/base/view_event_test_base.cc.rej

Patch:       chrome/test/base/view_event_test_base.cc
Index: chrome/test/base/view_event_test_base.cc
diff --git a/chrome/test/base/view_event_test_base.cc
b/chrome/test/base/view_event_test_base.cc
index
240f63fb098183ab7756b7b04175660902c9fbda..bbc2a0a98c76ce97e4a230641563e1001a12cea3
100644
--- a/chrome/test/base/view_event_test_base.cc
+++ b/chrome/test/base/view_event_test_base.cc
@@ -13,7 +13,6 @@
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/browser_thread.h"
 #include "ui/base/ime/text_input_test_support.h"
-#include "ui/compositor/test/compositor_test_support.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/desktop_aura/desktop_screen.h"
 #include "ui/views/widget/widget.h"
@@ -102,7 +101,6 @@ void ViewEventTestBase::Done() {
 
 void ViewEventTestBase::SetUp() {
   ui::TextInputTestSupport::Initialize();
-  ui::CompositorTestSupport::Initialize();
   gfx::NativeView context = NULL;
 #if defined(USE_ASH)
 #if defined(OS_WIN)
@@ -163,7 +161,6 @@ void ViewEventTestBase::TearDown() {
 #elif defined(USE_AURA)
   aura_test_helper_->TearDown();
 #endif
-  ui::CompositorTestSupport::Terminate();
   ui::TextInputTestSupport::Shutdown();
 }

[commit-bot: I haz the power, 2013-05-11 22:47:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14744016/17001

[commit-bot: I haz the power, 2013-05-11 22:57:39]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-05-12 01:26:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14744016/17001

[commit-bot: I haz the power, 2013-05-12 02:03:15]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-05-13 02:28:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14744016/17001

[commit-bot: I haz the power, 2013-05-13 02:28:33]

Failed to apply patch for chrome/test/base/view_event_test_base.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/test/base/view_event_test_base.cc
  Hunk #1 FAILED at 13.
  Hunk #2 succeeded at 103 (offset 3 lines).
  Hunk #3 succeeded at 163 (offset 7 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/test/base/view_event_test_base.cc.rej

Patch:       chrome/test/base/view_event_test_base.cc
Index: chrome/test/base/view_event_test_base.cc
diff --git a/chrome/test/base/view_event_test_base.cc
b/chrome/test/base/view_event_test_base.cc
index
a23a9ca606610a470fc80872d65320dfafe8f709..d37bd3627fb5defe1b9b58699e41c7a3fce9a0e8
100644
--- a/chrome/test/base/view_event_test_base.cc
+++ b/chrome/test/base/view_event_test_base.cc
@@ -13,7 +13,6 @@
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/browser_thread.h"
 #include "ui/base/ime/text_input_test_support.h"
-#include "ui/compositor/test/compositor_test_support.h"
 #include "ui/message_center/message_center.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/desktop_aura/desktop_screen.h"
@@ -100,7 +99,6 @@ void ViewEventTestBase::Done() {
 
 void ViewEventTestBase::SetUp() {
   ui::TextInputTestSupport::Initialize();
-  ui::CompositorTestSupport::Initialize();
   gfx::NativeView context = NULL;
 #if defined(USE_ASH)
 #if defined(OS_WIN)
@@ -157,7 +155,6 @@ void ViewEventTestBase::TearDown() {
 #elif defined(USE_AURA)
   aura_test_helper_->TearDown();
 #endif
-  ui::CompositorTestSupport::Terminate();
   ui::TextInputTestSupport::Shutdown();
 }

[commit-bot: I haz the power, 2013-05-13 22:09:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14744016/32001

[commit-bot: I haz the power, 2013-05-14 01:39:29]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[jamesr, 2013-05-14 04:17:17]

On 2013/05/14 01:39:29, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on win.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

Link error is this:

FAILED: E:\b\depot_tools\python_bin\python.exe gyp-win-tool link-wrapper
environment.x86 link.exe /nologo /OUT:interactive_ui_tests.exe
/PDB:interactive_ui_tests.exe.pdb @interactive_ui_tests.exe.rsp &&
E:\b\depot_tools\python_bin\python.exe gyp-win-tool manifest-wrapper
environment.x86 cmd /c if exist interactive_ui_tests.exe.manifest del
interactive_ui_tests.exe.manifest && E:\b\depot_tools\python_bin\python.exe
gyp-win-tool manifest-wrapper environment.x86 mt.exe -nologo -manifest
obj\chrome\interactive_ui_tests.interactive_ui_tests.exe.intermediate.manifest
-out:interactive_ui_tests.exe.manifest
webkit_support_common.mock_webhyphenator.obj :error LNK2019: unresolved external
symbol _hnj_hyphen_free referenced in function "public: virtual __thiscall
webkit_glue::MockWebHyphenator::~MockWebHyphenator(void)"
(??1MockWebHyphenator@webkit_glue@@UAE@XZ)

webkit_support_common.mock_webhyphenator.obj :error LNK2019: unresolved external
symbol _hnj_hyphen_load_file referenced in function "public: void __thiscall
webkit_glue::MockWebHyphenator::LoadDictionary(void *)"
(?LoadDictionary@MockWebHyphenator@webkit_glue@@QAEXPAX@Z)

webkit_support_common.mock_webhyphenator.obj :error LNK2019: unresolved external
symbol _hnj_hyphen_hyphenate2 referenced in function "public: virtual unsigned
int __thiscall webkit_glue::MockWebHyphenator::computeLastHyphenLocation(wchar_t
const *,unsigned int,unsigned int,class WebKit::WebString const &)"
(?computeLastHyphenLocation@MockWebHyphenator@webkit_glue@@UAEIPB_WIIABVWebString@WebKit@@@Z)

interactive_ui_tests.exe : fatalerror LNK1120: 3 unresolved externals

ninja: build stopped: subcommand failed.

which means something is pulling webkit_support_common (which defines
webkit_glue::MockWebHyphenator) without pulling in third_party/hyphen/, which
defines those symbols.  I removed test_compositor_support's dependency on
webkit_support, which pulled that in.

I think the fix is that webkit_support_common should declare the dependency on
hyphen, since it uses it.  Will consult with the trybots...

[commit-bot: I haz the power, 2013-05-14 04:28:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14744016/29003

[commit-bot: I haz the power, 2013-05-14 04:28:59]

Failed to apply patch for chrome/test/base/view_event_test_base.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/test/base/view_event_test_base.cc
  Hunk #1 FAILED at 13.
  Hunk #2 succeeded at 103 (offset 3 lines).
  Hunk #3 succeeded at 163 (offset 7 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/test/base/view_event_test_base.cc.rej

Patch:       chrome/test/base/view_event_test_base.cc
Index: chrome/test/base/view_event_test_base.cc
diff --git a/chrome/test/base/view_event_test_base.cc
b/chrome/test/base/view_event_test_base.cc
index
a23a9ca606610a470fc80872d65320dfafe8f709..d37bd3627fb5defe1b9b58699e41c7a3fce9a0e8
100644
--- a/chrome/test/base/view_event_test_base.cc
+++ b/chrome/test/base/view_event_test_base.cc
@@ -13,7 +13,6 @@
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/browser_thread.h"
 #include "ui/base/ime/text_input_test_support.h"
-#include "ui/compositor/test/compositor_test_support.h"
 #include "ui/message_center/message_center.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/desktop_aura/desktop_screen.h"
@@ -100,7 +99,6 @@ void ViewEventTestBase::Done() {
 
 void ViewEventTestBase::SetUp() {
   ui::TextInputTestSupport::Initialize();
-  ui::CompositorTestSupport::Initialize();
   gfx::NativeView context = NULL;
 #if defined(USE_ASH)
 #if defined(OS_WIN)
@@ -157,7 +155,6 @@ void ViewEventTestBase::TearDown() {
 #elif defined(USE_AURA)
   aura_test_helper_->TearDown();
 #endif
-  ui::CompositorTestSupport::Terminate();
   ui::TextInputTestSupport::Shutdown();
 }

[jamesr, 2013-05-29 00:53:45]

I forgot about this patch for a bit and now things are a little different - the
compositor_test_support target now has some additional useful things (like
test_layers), so I've left it in and only removed the CompositorTestSupport
class.

piman - PTAL
sky - could you look at the ash/ and ui/aura/, and ui/(non-compositor) changes? 
They're mostly fairly trivial.

[piman, 2013-05-29 00:59:10]

lgtm

[sky, 2013-05-29 01:11:06]

LGTM

[commit-bot: I haz the power, 2013-05-29 01:31:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14744016/68001

[commit-bot: I haz the power, 2013-05-29 06:51:09]

Change committed as 202787

[commit-bot: I haz the power, 2013-05-29 23:27:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14744016/92001

[jamesr, 2013-05-29 23:32:22]

This was reverted due to missing compositor_test_support dependencies in some
tests in ui/snapshot/.. and ui/views/widget/.... I've added these and confirmed
that all targets build in linux_chromeos debug. Relanding.

[commit-bot: I haz the power, 2013-05-30 03:34:41]

Change committed as 203042