Source/core/page/DOMWindow.cpp - Issue 14735005: Disallow a window focusing itself via javascript URLs or using target _self

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DOMWindow.cpp

Issue 14735005: Disallow a window focusing itself via javascript URLs or using target _self (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/DOMWindow.cpp

diff --git a/Source/core/page/DOMWindow.cpp b/Source/core/page/DOMWindow.cpp

index ca9f0fab7cbb48adacfb9382bec31f0c15bf4568..cbaf4401241912088deeae40eb54b2840c9744da 100644

--- a/Source/core/page/DOMWindow.cpp

+++ b/Source/core/page/DOMWindow.cpp

@@ -860,7 +860,7 @@ void DOMWindow::focus(ScriptExecutionContext* context)

if (context) {

ASSERT(isMainThread());

Document* activeDocument = toDocument(context);

- if (opener() && activeDocument->domWindow() == opener())

+ if (opener() && opener() != this && activeDocument->domWindow() == opener())

allowFocus = true;

}

« no previous file with comments | « Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »