Source/core/loader/FrameLoader.cpp - Issue 14735005: Disallow a window focusing itself via javascript URLs or using target _self

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 14735005: Disallow a window focusing itself via javascript URLs or using target _self (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/FrameLoader.cpp

diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp

index 8df20a4911bbd4a78e63b5f00d587756d950906d..40d82d4513f1a22c14ae5973694a27ef189ab067 100644

--- a/Source/core/loader/FrameLoader.cpp

+++ b/Source/core/loader/FrameLoader.cpp

@@ -2926,8 +2926,10 @@ Frame* createWindow(Frame* openerFrame, Frame* lookupFrame, const FrameLoadReque

if (!request.frameName().isEmpty() && request.frameName() != "_blank") {

if (Frame* frame = lookupFrame->loader()->findFrameForNavigation(request.frameName(), openerFrame->document())) {

- if (Page* page = frame->page())

- page->chrome()->focus();

+ if (request.frameName() != "_self") {

+ if (Page* page = frame->page())

+ page->chrome()->focus();

+ }

created = false;

return frame;

}