Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 14735005: Disallow a window focusing itself via javascript URLs or using target _self (Closed)

Created:
7 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 7 months ago
Reviewers:
Mike West
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Disallow a window focusing itself via javascript URLs or using target _self Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
A LayoutTests/fast/dom/Window/window-focus-self.html View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Window/window-focus-self-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/page/DOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
Clever popunders... Fix looks reasonable: LGTM.
7 years, 7 months ago (2013-05-06 13:44:50 UTC) #1
Mike West
On 2013/05/06 13:44:50, Mike West (chromium) wrote: > Clever popunders... Fix looks reasonable: LGTM. Would ...
7 years, 7 months ago (2013-05-06 13:49:35 UTC) #2
jochen (gone - plz use gerrit)
On 2013/05/06 13:49:35, Mike West (chromium) wrote: > On 2013/05/06 13:44:50, Mike West (chromium) wrote: ...
7 years, 7 months ago (2013-05-06 13:58:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/14735005/1
7 years, 7 months ago (2013-05-06 13:59:17 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 14:03:06 UTC) #5
Message was sent while issue was closed.
Change committed as 149731

Powered by Google App Engine
This is Rietveld 408576698