Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1473383002: Moved Perf to systemd and also move to using tracedb. (Closed)

Created:
5 years ago by jcgregorio
Modified:
5 years ago
Reviewers:
tfarina, stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Moved Perf to systemd and also move to using tracedb. This CL depends on https://codereview.chromium.org/1411633008. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/2d785973eb46e916f806200c9024d6c4a075e6a7

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -405 lines) Patch
M compute_engine_scripts/perf/README.md View 1 chunk +1 line, -1 line 0 comments Download
M compute_engine_scripts/perf/vm_config.sh View 1 chunk +4 lines, -11 lines 1 comment Download
M compute_engine_scripts/perf/vm_create_instance.sh View 1 chunk +28 lines, -7 lines 1 comment Download
M compute_engine_scripts/perf/vm_delete_instance.sh View 2 chunks +2 lines, -3 lines 1 comment Download
M perf/Makefile View 2 chunks +1 line, -5 lines 0 comments Download
M perf/build_release View 2 chunks +9 lines, -23 lines 0 comments Download
D perf/res/css/main.css View 1 chunk +0 lines, -8 lines 0 comments Download
D perf/sys/ingest_init View 1 chunk +0 lines, -160 lines 0 comments Download
D perf/sys/ingest_monit View 1 chunk +0 lines, -13 lines 0 comments Download
D perf/sys/perf_init View 1 chunk +0 lines, -160 lines 0 comments Download
D perf/sys/perf_monit View 1 chunk +0 lines, -13 lines 0 comments Download
A perf/sys/skiaperfd.service View 1 chunk +19 lines, -0 lines 0 comments Download
M push/skiapush.conf View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jcgregorio
5 years ago (2015-11-24 19:25:17 UTC) #2
stephana
On 2015/11/24 19:25:17, jcgregorio wrote: lgtm
5 years ago (2015-11-24 21:54:13 UTC) #3
tfarina
https://codereview.chromium.org/1473383002/diff/1/compute_engine_scripts/perf/vm_config.sh File compute_engine_scripts/perf/vm_config.sh (right): https://codereview.chromium.org/1473383002/diff/1/compute_engine_scripts/perf/vm_config.sh#newcode6 compute_engine_scripts/perf/vm_config.sh:6: # Copyright 2015 Google Inc. All Rights Reserved. keep ...
5 years ago (2015-11-26 21:01:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473383002/1
5 years ago (2015-11-28 14:51:40 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-28 14:54:39 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/buildbot/+/2d785973eb46e916f806200c9024d6c4a075...

Powered by Google App Engine
This is Rietveld 408576698