Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 14695002: Remove Pepper URLLoader from resource tracker early. (Closed)

Created:
7 years, 7 months ago by bbudge
Modified:
7 years, 7 months ago
Reviewers:
Tom Sepez, viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Remove Pepper URLLoader from resource tracker early. This protects against double delete if the instance is destroyed as a result of canceling a load. BUG=159429, 227350 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197686

Patch Set 1 #

Patch Set 2 : Original fix, with a TODO. #

Patch Set 3 : Move TODO to logical place. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M ppapi/shared_impl/resource.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ppapi/shared_impl/resource.cc View 2 chunks +5 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_url_loader_impl.cc View 1 2 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bbudge
The URLLoader is being refactored to the new resource system, which may fix this. However, ...
7 years, 7 months ago (2013-04-30 21:32:05 UTC) #1
Tom Sepez
Looks good, but I'll defer to Trung.
7 years, 7 months ago (2013-04-30 21:34:57 UTC) #2
viettrungluu
lgtm
7 years, 7 months ago (2013-05-01 17:53:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/14695002/12001
7 years, 7 months ago (2013-05-01 17:57:37 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-01 19:23:37 UTC) #5
Message was sent while issue was closed.
Change committed as 197686

Powered by Google App Engine
This is Rietveld 408576698