Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: ppapi/shared_impl/resource.h

Issue 14695002: Remove Pepper URLLoader from resource tracker early. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move TODO to logical place. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/shared_impl/resource.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/resource.h
diff --git a/ppapi/shared_impl/resource.h b/ppapi/shared_impl/resource.h
index ddfdcfbfd7de98c7ebc5ccbcaa15adf08ec577b4..7fffd4af210ad559961f7a310107be33bb056969 100644
--- a/ppapi/shared_impl/resource.h
+++ b/ppapi/shared_impl/resource.h
@@ -208,6 +208,14 @@ class PPAPI_SHARED_EXPORT Resource : public base::RefCounted<Resource> {
// Logs a message to the console from this resource.
void Log(PP_LogLevel level, const std::string& message);
+ // Removes the resource from the ResourceTracker's tables. This normally
+ // happens as part of Resource destruction, but if a subclass destructor
+ // has a risk of re-entering destruction via the ResourceTracker, it can
+ // call this explicitly to get rid of the table entry before continuing
+ // with the destruction. If the resource is not in the ResourceTracker's
+ // tables, silently does nothing. See http://crbug.com/159429.
+ void RemoveFromResourceTracker();
+
// Notifications for subclasses.
virtual void LastPluginRefWasDeleted() {}
virtual void InstanceWasDeleted() {}
« no previous file with comments | « no previous file | ppapi/shared_impl/resource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698