Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 14688008: Revert 149589 "Set a bit on Custom Elements on creation to simplify wrapping" (Closed)

Created:
7 years, 7 months ago by dstockwell
Modified:
7 years, 7 months ago
CC:
blink-reviews, haraken, Nate Chapin, jsbell+bindings_chromium.org, abarth-chromium
Visibility:
Public.

Description

Revert 149589 "Set a bit on Custom Elements on creation to simplify wrapping" > Set a bit on Custom Elements on creation to simplify wrapping > For now, this makes wrapping faster because the wrapper factory can > check this bit instead of examining the tag name and "is" attribute. > > This bit will soon be required for correctness: Currently, because > elements are only activated at creation time, there is no window in > which the "is" attribute can be changed by script before the element > is upgraded. Soon we will do post-hoc upgrade of custom elements > created before their definitions are available. This bit will be > necessary for opting elements into that processing. > > BUG=233775 > > Review URL: https://chromiumcodereview.appspot.com/14834002 fast/dom/wrapper-classes.html crashes on debug builds NOTRY=true TBR=dominicc@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M Source/bindings/v8/CustomElementHelpers.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/v8/CustomElementHelpers.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/dom/CustomElementRegistry.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/CustomElementRegistry.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/core/dom/Node.h View 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/scripts/make_names.pl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dstockwell
7 years, 7 months ago (2013-05-02 13:11:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/14688008/1
7 years, 7 months ago (2013-05-02 13:11:18 UTC) #2
commit-bot: I haz the power
Change committed as 149593
7 years, 7 months ago (2013-05-02 13:11:32 UTC) #3
dominicc (has gone to gerrit)
7 years, 7 months ago (2013-05-02 15:03:29 UTC) #4
Message was sent while issue was closed.
Interesting. Thanks for rolling out; I will investigate.

Powered by Google App Engine
This is Rietveld 408576698