Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1465673002: Document the Inspect event in the service protocol. (Closed)

Created:
5 years, 1 month ago by rmacnak
Modified:
5 years ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Document the Inspect event in the service protocol. BUG=http://dartbug.com/24998 R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/c0a0c92a5e9533b42a13f76ef9708e82cccfb84d

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M runtime/vm/service/service.md View 1 2 chunks +9 lines, -1 line 2 comments Download

Messages

Total messages: 7 (1 generated)
rmacnak
5 years, 1 month ago (2015-11-20 00:09:23 UTC) #2
Cutch
On 2015/11/20 00:09:23, rmacnak wrote: I worry about us rushing to add things to service.md ...
5 years, 1 month ago (2015-11-20 21:04:09 UTC) #3
turnidge
https://codereview.chromium.org/1465673002/diff/20001/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1465673002/diff/20001/runtime/vm/service/service.md#newcode720 runtime/vm/service/service.md:720: GC | GC You should add the event type ...
5 years ago (2015-11-23 23:54:40 UTC) #4
turnidge
lgtm
5 years ago (2015-11-24 00:27:17 UTC) #5
rmacnak
https://chromiumcodereview.appspot.com/1465673002/diff/20001/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://chromiumcodereview.appspot.com/1465673002/diff/20001/runtime/vm/service/service.md#newcode720 runtime/vm/service/service.md:720: GC | GC On 2015/11/23 23:54:40, turnidge wrote: > ...
5 years ago (2015-11-24 00:55:59 UTC) #6
rmacnak
5 years ago (2015-11-24 00:56:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c0a0c92a5e9533b42a13f76ef9708e82cccfb84d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698