Make Label's NO_ELIDE setting actually not elide, and change the default

Make Label's NO_ELIDE setting actually not elide, and change the default
behavior to ELIDE_AT_END.  This makes the content settings banner in the
omnibox look better, since it now just chops the end of the text off while it's
animating in instead of eliding it.

For non-Linux, non-multiline labels, this means that instead of calling
ui::ElideText(..., ui::ELIDE_AT_END) indirectly from
Canvas::DrawStringWithShadows(), we now call it in
Label::CalculateDrawStringParams().  Presumably this makes no difference, unless
there's something weirdly different about the bounds supplied to the ElideText()
calls in those two places.

For OS_LINUX, this means that non-multiline LTR Labels will now be elided using
ui::ElideText() (and thus will use an ellipsis) by default, instead of being
faded at the right edge.  I don't know how many such elided labels exist on
Linux, so it's hard for me to evaluate the impact of this change.  Note that
callers directly to the canvas string-drawing functions are unaffected by this.

BUG=none
TEST=none
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200850

[Peter Kasting, 2013-05-17 01:13:27]

sky: General review/OWNERS
asvitkine: You originally added the "fade at end" behavior to canvas_skia.cc for
Linux, which would now be used less frequently; I'm wondering if you know the
impact of this change.  (See change description paragraph 3.)
erg: Also sending to you as another person who might know how to gauge the
impact of change description paragraph 3.

[Alexei Svitkine (slow), 2013-05-17 13:49:52]

> asvitkine: You originally added the "fade at end" behavior to canvas_skia.cc
for
> Linux, which would now be used less frequently; I'm wondering if you know the
> impact of this change.  (See change description paragraph 3.)

Although I added the "fade at end" behavior to canvas_skia.cc, it was done to
match the behavior of canvas_linux.cc which I was replacing with canvas_skia.cc,
so I'm not sure what higher level code uses a Label to get that behaviour.

I don't recall what parts of the UI actually faded the text - perhaps items on
the bookmark bar? But maybe those don't use labels.

Sorry that I'm not much help here.

https://codereview.chromium.org/14654018/diff/22001/ui/views/controls/label.h
File ui/views/controls/label.h (right):

https://codereview.chromium.org/14654018/diff/22001/ui/views/controls/label.h...
ui/views/controls/label.h:135: // necessary). The default is to to elide at the
end.
Nit: "to to" -> "to"

[Alexei Svitkine (slow), 2013-05-17 13:52:17]

Also, it occurs to me that in reality this should only affect ChromeOS, since
it's the only OS_LINUX platform that should be using views Label (well, that and
erg's work on Linux Aura, but that's not shipping yet). So it may be worthwhile
to loop in some ChromeOS UI folks here.

[sky, 2013-05-17 15:56:13]

LGTM

[sky, 2013-05-17 15:57:14]

The only part of the ui I know that fades at the end is the titles in
the tabstrip. Tab calls Canvas::DrawFadeTruncatingString.

On Fri, May 17, 2013 at 6:49 AM,  <asvitkine@chromium.org> wrote:
>> asvitkine: You originally added the "fade at end" behavior to
>> canvas_skia.cc
>
> for
>>
>> Linux, which would now be used less frequently; I'm wondering if you know
>> the
>> impact of this change.  (See change description paragraph 3.)
>
>
> Although I added the "fade at end" behavior to canvas_skia.cc, it was done
> to
> match the behavior of canvas_linux.cc which I was replacing with
> canvas_skia.cc,
> so I'm not sure what higher level code uses a Label to get that behaviour.
>
> I don't recall what parts of the UI actually faded the text - perhaps items
> on
> the bookmark bar? But maybe those don't use labels.
>
> Sorry that I'm not much help here.
>
>
> https://codereview.chromium.org/14654018/diff/22001/ui/views/controls/label.h
> File ui/views/controls/label.h (right):
>
>
https://codereview.chromium.org/14654018/diff/22001/ui/views/controls/label.h...
> ui/views/controls/label.h:135: // necessary). The default is to to elide
> at the end.
> Nit: "to to" -> "to"
>
> https://codereview.chromium.org/14654018/

[tfarina, 2013-05-17 16:37:01]

Bookmark buttons in Bookmarks Bar do not fade the title, they elide
them with elipses at end.

-- 
Thiago

[Peter Kasting, 2013-05-17 17:55:58]

OK, I'm happy enough to just land this.

[Peter Kasting, 2013-05-17 17:57:26]

Committed patchset #2 manually as r200850 (presubmit successful).