Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 14652004: Don't use crtbegin/crtend in android_webview builds. (Closed)

Created:
7 years, 7 months ago by mkosiba (inactive)
Modified:
7 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews
Visibility:
Public.

Description

Don't use crtbegin/crtend in android_webview builds. This was working due to a fluke in the Android.mk GYP generator. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197407

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M build/common.gypi View 1 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mkosiba (inactive)
PTAL
7 years, 7 months ago (2013-04-30 15:06:25 UTC) #1
Torne
lgtm
7 years, 7 months ago (2013-04-30 15:12:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/14652004/4001
7 years, 7 months ago (2013-04-30 15:39:16 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-04-30 18:00:24 UTC) #4
Message was sent while issue was closed.
Change committed as 197407

Powered by Google App Engine
This is Rietveld 408576698