Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: build/common.gypi

Issue 14652004: Don't use crtbegin/crtend in android_webview builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3527 matching lines...) Expand 10 before | Expand all | Expand 10 after
3538 ], 3538 ],
3539 'ldflags': [ 3539 'ldflags': [
3540 '-pie', 3540 '-pie',
3541 ], 3541 ],
3542 }], 3542 }],
3543 ], 3543 ],
3544 }], 3544 }],
3545 ['_type=="shared_library" or _type=="loadable_module"', { 3545 ['_type=="shared_library" or _type=="loadable_module"', {
3546 'ldflags': [ 3546 'ldflags': [
3547 '-Wl,-shared,-Bsymbolic', 3547 '-Wl,-shared,-Bsymbolic',
3548 # crtbegin_so.o should be the last item in ldflags.
3549 '<(android_ndk_lib)/crtbegin_so.o',
3550 ], 3548 ],
3551 'libraries': [ 3549 'conditions': [
3552 # crtend_so.o needs to be the last item in libraries. 3550 ['android_webview_build==0', {
3553 # Do not add any libraries after this! 3551 'ldflags': [
3554 '<(android_ndk_lib)/crtend_so.o', 3552 # crtbegin_so.o should be the last item in ldflags.
3553 '<(android_ndk_lib)/crtbegin_so.o',
3554 ],
3555 'libraries': [
3556 # crtend_so.o needs to be the last item in libraries.
3557 # Do not add any libraries after this!
3558 '<(android_ndk_lib)/crtend_so.o',
3559 ],
3560 }],
3555 ], 3561 ],
3556 }], 3562 }],
3557 ], 3563 ],
3558 }], 3564 }],
3559 # Settings for building host targets using the system toolchain. 3565 # Settings for building host targets using the system toolchain.
3560 ['_toolset=="host"', { 3566 ['_toolset=="host"', {
3561 'cflags!': [ 3567 'cflags!': [
3562 # Due to issues in Clang build system, using ASan on 32-bit 3568 # Due to issues in Clang build system, using ASan on 32-bit
3563 # binaries on x86_64 host is problematic. 3569 # binaries on x86_64 host is problematic.
3564 # TODO(eugenis): re-enable. 3570 # TODO(eugenis): re-enable.
(...skipping 798 matching lines...) Expand 10 before | Expand all | Expand 10 after
4363 # settings in target dicts. SYMROOT is a special case, because many other 4369 # settings in target dicts. SYMROOT is a special case, because many other
4364 # Xcode variables depend on it, including variables such as 4370 # Xcode variables depend on it, including variables such as
4365 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4371 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4366 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4372 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4367 # files to appear (when present) in the UI as actual files and not red 4373 # files to appear (when present) in the UI as actual files and not red
4368 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4374 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4369 # and therefore SYMROOT, needs to be set at the project level. 4375 # and therefore SYMROOT, needs to be set at the project level.
4370 'SYMROOT': '<(DEPTH)/xcodebuild', 4376 'SYMROOT': '<(DEPTH)/xcodebuild',
4371 }, 4377 },
4372 } 4378 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698