Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 14651028: Promote RenderLayers that have a transition on opacity, transform, or filter (Closed)

Created:
7 years, 7 months ago by ajuma
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, Ian Vollick, danakj, shawnsingh, nduca, Vangelis Kokkevis
Visibility:
Public.

Description

Promote RenderLayers that have a transition on opacity, transform, or filter This is behind a setting that is false by default. By promoting these layers ahead of time (rather than waiting for a transition to start), we avoid janking at the start of a transition while we paint the newly-promoted layer. BUG=178119 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150600

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -19 lines) Patch
A LayoutTests/compositing/transitions/transitions-have-composited-layers.html View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A LayoutTests/compositing/transitions/transitions-have-composited-layers-expected.txt View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/public/WebSettings.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/page/Settings.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 1 chunk +20 lines, -19 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 2 4 chunks +22 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/DumpRenderTree.cpp View 1 2 4 chunks +5 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestShell.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestShell.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ajuma
PTAL. Note that http://crrev.com/13620006 and http://crrev.com/14656003 attempted to lower-bound the memory impact of this by ...
7 years, 7 months ago (2013-05-15 17:42:32 UTC) #1
jamesr
I'm a little concerned about the impact on text quality. Maybe we could try this ...
7 years, 7 months ago (2013-05-15 18:35:19 UTC) #2
shawnsingh
The code looks good to me; I agree with James' concern about text AA. Is ...
7 years, 7 months ago (2013-05-15 19:24:43 UTC) #3
ajuma
On 2013/05/15 19:24:43, shawnsingh wrote: > The code looks good to me; I agree with ...
7 years, 7 months ago (2013-05-15 19:42:22 UTC) #4
enne (OOO)
jamesr: I have the same concerns as everybody else here wrt text quality. Other than ...
7 years, 7 months ago (2013-05-15 22:48:24 UTC) #5
ajuma
PTAL. I've put this behind a setting that's false by default, and I've posted a ...
7 years, 7 months ago (2013-05-17 17:21:29 UTC) #6
jamesr
lgtm
7 years, 7 months ago (2013-05-17 18:10:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/14651028/40001
7 years, 7 months ago (2013-05-17 19:05:35 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 19:26:48 UTC) #9
Message was sent while issue was closed.
Change committed as 150600

Powered by Google App Engine
This is Rietveld 408576698