Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 14651017: Move RuntimeData and related permissions out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_permissions
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index eb8796329d70e0b96f0c59e7e2e29d0d0dfd6dcf..4c1ac581cc0e16608d94f4c967beb30af70ab311 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -24,6 +24,7 @@
#include "chrome/common/extensions/manifest.h"
#include "chrome/common/extensions/message_bundle.h"
#include "chrome/common/extensions/permissions/permission_set.h"
+#include "chrome/common/extensions/permissions/permissions_data.h"
#include "chrome/common/url_constants.h"
#include "chrome/renderer/chrome_render_process_observer.h"
#include "chrome/renderer/extensions/api_activity_logger.h"
@@ -1275,7 +1276,7 @@ void Dispatcher::OnUpdatePermissions(int reason_id,
break;
}
- extension->SetActivePermissions(new_active);
+ PermissionsData::SetActivePermissions(extension, new_active);
AddOrRemoveOriginPermissions(reason, extension, explicit_hosts);
}
@@ -1297,7 +1298,8 @@ void Dispatcher::OnUpdateTabSpecificPermissions(
if (!extension)
return;
- extension->UpdateTabSpecificPermissions(
+ PermissionsData::UpdateTabSpecificPermissions(
+ extension,
tab_id,
new PermissionSet(APIPermissionSet(), origin_set, URLPatternSet()));
}
@@ -1309,7 +1311,7 @@ void Dispatcher::OnClearTabSpecificPermissions(
it != extension_ids.end(); ++it) {
const Extension* extension = extensions_.GetByID(*it);
if (extension)
- extension->ClearTabSpecificPermissions(tab_id);
+ PermissionsData::ClearTabSpecificPermissions(extension, tab_id);
}
}

Powered by Google App Engine
This is Rietveld 408576698