chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc - Issue 14651017: Move RuntimeData and related permissions out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc

Issue 14651017: Move RuntimeData and related permissions out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_permissions

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc ('K') | « chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc ('k') | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | chrome/common/extensions/permissions/permissions_data.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc

index a9a67bef0c5c24c0ce2c04abf6d2176c6b89977c..f7a7ed6357945d0d350c82c2365888129d79d37a 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc

@@ -6,6 +6,7 @@

#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

#include "chrome/common/extensions/manifest_url_handler.h"

+#include "chrome/common/extensions/permissions/permissions_data.h"

#include "testing/gtest/include/gtest/gtest.h"

class DevToolsPageManifestTest : public ExtensionManifestTest {

@@ -19,5 +20,6 @@ TEST_F(DevToolsPageManifestTest, DevToolsExtensions) {

extension = LoadAndExpectSuccess("devtools_extension.json");

EXPECT_EQ(extension->url().spec() + "devtools.html",

extensions::ManifestURL::GetDevToolsPage(extension).spec());

- EXPECT_TRUE(extension->HasEffectiveAccessToAllHosts());

+ EXPECT_TRUE(

+ extensions::PermissionsData::HasEffectiveAccessToAllHosts(extension));

}