chrome/common/extensions/extension_messages.cc - Issue 14651017: Move RuntimeData and related permissions out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_messages.cc

Issue 14651017: Move RuntimeData and related permissions out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_permissions

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension.h ('K') | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_messages.cc

diff --git a/chrome/common/extensions/extension_messages.cc b/chrome/common/extensions/extension_messages.cc

index 87eb43f6fb86b9bef5554590504d5ae6fce74d7c..44b475878c1421aca7da13dff846b3a9bb952cc6 100644

--- a/chrome/common/extensions/extension_messages.cc

+++ b/chrome/common/extensions/extension_messages.cc

@@ -7,6 +7,7 @@

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/manifest.h"

+#include "chrome/common/extensions/permissions/permissions_data.h"

#include "chrome/common/extensions/permissions/permissions_info.h"

#include "content/public/common/common_param_traits.h"

@@ -42,8 +43,9 @@ scoped_refptr<Extension> ExtensionMsg_Loaded_Params::ConvertToExtension(

scoped_refptr<Extension> extension =

Extension::Create(path, location, *manifest, creation_flags, error);

if (extension) {

- extension->SetActivePermissions(

- new PermissionSet(apis, explicit_hosts, scriptable_hosts));

+ extensions::PermissionsData::SetActivePermissions(

+ extension,

+ new PermissionSet(apis, explicit_hosts, scriptable_hosts));

}

return extension;

}