chrome/browser/extensions/api/management/management_api.cc - Issue 14651017: Move RuntimeData and related permissions out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 14651017: Move RuntimeData and related permissions out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_permissions

Patch Set: Latest master Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/extensions/api/media_galleries/media_galleries_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index 84700caadd2bf1df2f69d17e02a38d18d6c7e6cb..a1bd36ef5adebac03f257aaca0a09f4e439489d0 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -38,6 +38,7 @@

#include "chrome/common/extensions/manifest_handlers/offline_enabled_info.h"

#include "chrome/common/extensions/manifest_url_handler.h"

#include "chrome/common/extensions/permissions/permission_set.h"

+#include "chrome/common/extensions/permissions/permissions_data.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_source.h"

#include "content/public/browser/utility_process_host.h"

@@ -76,7 +77,8 @@ AutoConfirmForTest auto_confirm_for_test = DO_NOT_SKIP;

std::vector<std::string> CreateWarningsList(const Extension* extension) {

std::vector<std::string> warnings_list;

- PermissionMessages warnings = extension->GetPermissionMessages();

+ PermissionMessages warnings =

+ PermissionsData::GetPermissionMessages(extension);

for (PermissionMessages::const_iterator iter = warnings.begin();

iter != warnings.end(); ++iter) {

warnings_list.push_back(UTF16ToUTF8(iter->message()));