Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 14647004: Small cleanup in build/linux/install-arm-sysroot.py. (Closed)

Created:
7 years, 7 months ago by Lei Zhang
Modified:
7 years, 7 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews
Visibility:
Public.

Description

Small cleanup in build/linux/install-arm-sysroot.py and fix a typo in DEPS. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199337

Patch Set 1 #

Patch Set 2 : another typo fix #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M DEPS View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M build/linux/install-arm-sysroot.py View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
7 years, 7 months ago (2013-05-04 02:23:58 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/14647004/diff/6001/build/linux/install-arm-sysroot.py File build/linux/install-arm-sysroot.py (right): https://codereview.chromium.org/14647004/diff/6001/build/linux/install-arm-sysroot.py#newcode6 build/linux/install-arm-sysroot.py:6: # Script to install ARM chroot image for ...
7 years, 7 months ago (2013-05-04 05:15:58 UTC) #2
Lei Zhang
https://codereview.chromium.org/14647004/diff/6001/build/linux/install-arm-sysroot.py File build/linux/install-arm-sysroot.py (right): https://codereview.chromium.org/14647004/diff/6001/build/linux/install-arm-sysroot.py#newcode6 build/linux/install-arm-sysroot.py:6: # Script to install ARM chroot image for cross ...
7 years, 7 months ago (2013-05-07 03:34:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/14647004/10001
7 years, 7 months ago (2013-05-10 02:14:39 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 02:32:20 UTC) #5
Message was sent while issue was closed.
Change committed as 199337

Powered by Google App Engine
This is Rietveld 408576698