Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: build/linux/install-arm-sysroot.py

Issue 14647004: Small cleanup in build/linux/install-arm-sysroot.py. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/linux/install-arm-sysroot.py
===================================================================
--- build/linux/install-arm-sysroot.py (revision 198351)
+++ build/linux/install-arm-sysroot.py (working copy)
@@ -3,7 +3,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-# Script to install arm choot image for cross building of arm chrome on linux.
+# Script to install ARM root image for cross building of ARM chrome on linux.
# This script can be run manually but is more often run as part of gclient
# hooks. When run from hooks this script should be a no-op on non-linux
# platforms.
@@ -24,6 +24,7 @@
URL_PREFIX = 'https://commondatastorage.googleapis.com'
URL_PATH = 'nativeclient-archive2/toolchain'
REVISION = 10991
+TARBALL = 'naclsdk_linux_arm-trusted.tgz'
def main(args):
@@ -39,8 +40,7 @@
src_root = os.path.dirname(os.path.dirname(SCRIPT_DIR))
sysroot = os.path.join(src_root, 'arm-sysroot')
- url = "%s/%s/%s/naclsdk_linux_arm-trusted.tgz" % (URL_PREFIX,
- URL_PATH, REVISION)
+ url = "%s/%s/%s/%s" % (URL_PREFIX, URL_PATH, REVISION, TARBALL)
stamp = os.path.join(sysroot, ".stamp")
if os.path.exists(stamp):
@@ -53,7 +53,7 @@
if os.path.isdir(sysroot):
shutil.rmtree(sysroot)
os.mkdir(sysroot)
- tarball = os.path.join(sysroot, 'naclsdk_linux_arm-trusted.tgz')
+ tarball = os.path.join(sysroot, TARBALL)
subprocess.check_call(['curl', '-L', url, '-o', tarball])
subprocess.check_call(['tar', 'xf', tarball, '-C', sysroot])
os.remove(tarball)
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698