Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2854)

Unified Diff: dart/tests/compiler/dart2js_extra/mirror_test.dart

Issue 14646031: Implement invoke, setField, and getField (unminified). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/compiler/dart2js_extra/mirror_test.dart
diff --git a/dart/tests/compiler/dart2js_extra/mirror_test.dart b/dart/tests/compiler/dart2js_extra/mirror_test.dart
index 79de2b8143b7b55ed8fc8b66ffc0215d972c859b..dbc2b46b2acc6368c15005277bd054314a2a0053 100644
--- a/dart/tests/compiler/dart2js_extra/mirror_test.dart
+++ b/dart/tests/compiler/dart2js_extra/mirror_test.dart
@@ -14,7 +14,12 @@ void test(void onDone(bool success)) {
print('mirror.type: ${mirror.type}');
print('now.toUtc(): ${now.toUtc()}');
- mirror.invokeAsync("toUtc", []).then((value) {
+ var value = mirror.invoke(const Symbol("toUtc"), []);
+ print('mirror.invoke("toUtc", []): $value');
+ Expect.isTrue(value.hasReflectee);
+ Expect.equals(now.toUtc(), value.reflectee);
+
+ mirror.invokeAsync(const Symbol("toUtc"), []).then((value) {
print('mirror.invokeAsync("toUtc", []): $value');
Expect.isTrue(value.hasReflectee);
Expect.equals(now.toUtc(), value.reflectee);
@@ -23,18 +28,5 @@ void test(void onDone(bool success)) {
}
void main() {
- reflect("""
-
-This program is using an experimental feature called \"mirrors\". As
-currently implemented, mirrors do not work with minification, and will
-cause spurious errors depending on how code was optimized.
-
-The authors of this program are aware of these problems and have
-decided the thrill of using an experimental feature is outweighing the
-risks. Furthermore, the authors of this program understand that
-long-term, to fix the problems mentioned above, mirrors may have
-negative impact on size and performance of Dart programs compiled to
-JavaScript.
-""");
asyncTest(test);
}

Powered by Google App Engine
This is Rietveld 408576698