dart/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart - Issue 14646031: Implement invoke, setField, and getField (unminified).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

Issue 14646031: Implement invoke, setField, and getField (unminified). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | dart/tests/compiler/dart2js_extra/mirror_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart b/dart/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

index 24ed91d46df2b2b4d14c074f2fe2c0281b514585..789859b09641ccd1b3d4bf7bf4a370c0910e89ad 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

@@ -343,13 +343,13 @@ class InternalSimpleTypesInferrer extends TypesInferrer {

bool wasAnalyzed = analyzeCount.containsKey(element);

if (wasAnalyzed) {

recompiles++;

- recomputeWatch.start();

+ if (compiler.verbose) recomputeWatch.start();

}

bool changed =

compiler.withCurrentElement(element, () => analyze(element));

if (optimismState == RETRY) return true; // Abort.

analyzed++;

- if (wasAnalyzed) {

+ if (wasAnalyzed && compiler.verbose) {

recomputeWatch.stop();

}

checkAnalyzedAll();