Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 14634003: Fix the size of the tabs when exiting immersive fullscreen with the tab indicators hidden (Closed)

Created:
7 years, 7 months ago by pkotwicz
Modified:
7 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix the size of the tabs when exiting immersive fullscreen with the tab indicators hidden. The following occurs when exiting immersive fullscreen, in order: 1) The aura::Window's kShowStateKey is updated. This causes a layout of the BrowserView's non client view. (Note that BrowserView::ProcessFullscreen() does not disable laying out the non client view.) 2) Immersive fullscreen is disabled 3) BrowserView::Layout() This CL fixes a bug where the y position of the browser view in its parent is incorrect due to BrowserView::IsFullscreen() returning false and ImmersiveModeController::IsEnabled() returning true during step 1. BUG=233271 Test=Manual, see repro steps below 1) Run chrome with --ash-immersive-hide-tab-indicators --ash-enable-immersive-fullscreen 2) Use F4 to enter immersive fullscreen 3) With the top-of-window views hidden, hit F4 to exit immersive fullscreen 4) The tab strip should be properly visible Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198558

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 2 7 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
James PTAL. This fixes a regression because of https://chromiumcodereview.appspot.com/14340007
7 years, 7 months ago (2013-05-04 00:30:02 UTC) #1
James Cook
LGTM
7 years, 7 months ago (2013-05-05 22:04:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/14634003/4001
7 years, 7 months ago (2013-05-06 16:01:58 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 22:54:13 UTC) #4
Message was sent while issue was closed.
Change committed as 198558

Powered by Google App Engine
This is Rietveld 408576698