Source/modules/webaudio/OfflineAudioDestinationNode.cpp - Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/OfflineAudioDestinationNode.cpp

Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Require use of Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webaudio/OfflineAudioDestinationNode.cpp

diff --git a/Source/modules/webaudio/OfflineAudioDestinationNode.cpp b/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

index bb86eac80cb5f2394872bbc068c2e79087104902..c4b511aa2fde4a9ff90ec6c70affcc8e1f9e7ebb 100644

--- a/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

+++ b/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

@@ -46,7 +46,7 @@ OfflineAudioDestinationNode::OfflineAudioDestinationNode(AudioContext* context,

, m_renderThread(0)

, m_startedRendering(false)

{

- m_renderBus = adoptRef(new AudioBus(renderTarget->numberOfChannels(), renderQuantumSize));

+ m_renderBus = AudioBus::create(renderTarget->numberOfChannels(), renderQuantumSize);

}

OfflineAudioDestinationNode::~OfflineAudioDestinationNode()

« no previous file with comments | « Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp ('k') | Source/modules/webaudio/ScriptProcessorNode.h » ('j') | no next file with comments »