Source/core/platform/audio/chromium/AudioDestinationChromium.h - Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/audio/chromium/AudioDestinationChromium.h

Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Require use of Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/audio/SincResampler.cpp ('k') | Source/core/platform/audio/chromium/AudioDestinationChromium.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/audio/chromium/AudioDestinationChromium.h

diff --git a/Source/core/platform/audio/chromium/AudioDestinationChromium.h b/Source/core/platform/audio/chromium/AudioDestinationChromium.h

index f85797f70a0bf15e7897f1ff6732bbb05f9f3f82..16112b1d16383d23b5f5240f447a8055752a68f2 100644

--- a/Source/core/platform/audio/chromium/AudioDestinationChromium.h

+++ b/Source/core/platform/audio/chromium/AudioDestinationChromium.h

@@ -63,8 +63,8 @@ public:

private:

AudioIOCallback& m_callback;

unsigned m_numberOfOutputChannels;

- AudioBus m_inputBus;

- AudioBus m_renderBus;

+ RefPtr<AudioBus> m_inputBus;

+ RefPtr<AudioBus> m_renderBus;

float m_sampleRate;

bool m_isPlaying;

OwnPtr<WebKit::WebAudioDevice> m_audioDevice;

« no previous file with comments | « Source/core/platform/audio/SincResampler.cpp ('k') | Source/core/platform/audio/chromium/AudioDestinationChromium.cpp » ('j') | no next file with comments »