Source/modules/webaudio/ScriptProcessorNode.h - Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/webaudio/ScriptProcessorNode.h

Issue 14628008: Require use of AudioBus::create() to avoid ref-counting issues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Require use of Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/modules/webaudio/OfflineAudioDestinationNode.cpp ('k') | Source/modules/webaudio/ScriptProcessorNode.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010, Google Inc. All rights reserved.	2 * Copyright (C) 2010, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 88 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
99 virtual void derefEventTarget() { deref(); }	99 virtual void derefEventTarget() { deref(); }

100 EventTargetData m_eventTargetData;	100 EventTargetData m_eventTargetData;

101	101

102 size_t m_bufferSize;	102 size_t m_bufferSize;

103 unsigned m_bufferReadWriteIndex;	103 unsigned m_bufferReadWriteIndex;

104 volatile bool m_isRequestOutstanding;	104 volatile bool m_isRequestOutstanding;

105	105

106 unsigned m_numberOfInputChannels;	106 unsigned m_numberOfInputChannels;

107 unsigned m_numberOfOutputChannels;	107 unsigned m_numberOfOutputChannels;

108	108

109 AudioBus m_internalInputBus;	109 RefPtr<AudioBus> m_internalInputBus;

110 };	110 };

111	111

112 } // namespace WebCore	112 } // namespace WebCore

113	113

114 #endif // ScriptProcessorNode_h	114 #endif // ScriptProcessorNode_h

OLD	NEW