Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 14626003: drive: Rename DriveFileSystemMetadata to FileSystemMetadata (Closed)

Created:
7 years, 7 months ago by satorux1
Modified:
7 years, 7 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Rename DriveFileSystemMetadata to FileSystemMetadata As part of an effort to remove 'drive' prefix from c/b/chromeos/drive. BUG=231807 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197334

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -73 lines) Patch
M chrome/browser/chromeos/drive/drive_file_system.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_interface.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/drive/drive_file_system_metadata.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/chromeos/drive/drive_file_system_metadata.cc View 1 chunk +0 lines, -18 lines 0 comments Download
A + chrome/browser/chromeos/drive/file_system_metadata.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/chromeos/drive/file_system_metadata.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
7 years, 7 months ago (2013-04-30 08:03:44 UTC) #1
hashimoto
lgtm https://codereview.chromium.org/14626003/diff/1/chrome/browser/chromeos/drive/drive_file_system_interface.h File chrome/browser/chromeos/drive/drive_file_system_interface.h (right): https://codereview.chromium.org/14626003/diff/1/chrome/browser/chromeos/drive/drive_file_system_interface.h#newcode123 chrome/browser/chromeos/drive/drive_file_system_interface.h:123: // Used to get drive filesystem metadata. nit: ...
7 years, 7 months ago (2013-04-30 08:07:22 UTC) #2
satorux1
https://codereview.chromium.org/14626003/diff/1/chrome/browser/chromeos/drive/drive_file_system_interface.h File chrome/browser/chromeos/drive/drive_file_system_interface.h (right): https://codereview.chromium.org/14626003/diff/1/chrome/browser/chromeos/drive/drive_file_system_interface.h#newcode123 chrome/browser/chromeos/drive/drive_file_system_interface.h:123: // Used to get drive filesystem metadata. On 2013/04/30 ...
7 years, 7 months ago (2013-04-30 08:13:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/14626003/5001
7 years, 7 months ago (2013-04-30 08:14:06 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-04-30 10:40:18 UTC) #5
Message was sent while issue was closed.
Change committed as 197334

Powered by Google App Engine
This is Rietveld 408576698