Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 14622005: Free up 11 bits in fast-mode PropertyDetails by removing the enumeration-index. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Free up 11 bits in fast-mode PropertyDetails by removing the enumeration-index. The descriptors are nowadays ordered in order of addition, so that info was duplicated. Committed: https://code.google.com/p/v8/source/detail?r=14571

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -163 lines) Patch
M src/bootstrapper.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/heap.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.cc View 31 chunks +35 lines, -66 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects-inl.h View 6 chunks +1 line, -31 lines 0 comments Download
M src/property.h View 5 chunks +9 lines, -18 lines 0 comments Download
M src/property.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/property-details.h View 4 chunks +12 lines, -23 lines 0 comments Download
M src/runtime.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/string-stream.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-07 09:31:30 UTC) #1
Jakob Kummerow
lgtm
7 years, 7 months ago (2013-05-07 12:21:01 UTC) #2
Toon Verwaest
7 years, 7 months ago (2013-05-07 13:09:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698