Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: src/property.h

Issue 14622005: Free up 11 bits in fast-mode PropertyDetails by removing the enumeration-index. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | src/property.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/property.h
diff --git a/src/property.h b/src/property.h
index 229241948a8c4ee0dc253e199bdbd1710fdb8159..0dffe963b23591c21c6874f8a79182b7983c2224 100644
--- a/src/property.h
+++ b/src/property.h
@@ -64,11 +64,6 @@ class Descriptor BASE_EMBEDDED {
void Print(FILE* out);
#endif
- void SetEnumerationIndex(int index) {
- details_ = PropertyDetails(details_.attributes(), details_.type(),
- details_.representation(), index);
- }
-
void SetSortedKeyIndex(int index) { details_ = details_.set_pointer(index); }
private:
@@ -94,11 +89,10 @@ class Descriptor BASE_EMBEDDED {
Object* value,
PropertyAttributes attributes,
PropertyType type,
- Representation representation,
- int index)
+ Representation representation)
: key_(key),
value_(value),
- details_(attributes, type, representation, index) { }
+ details_(attributes, type, representation) { }
friend class DescriptorArray;
};
@@ -109,10 +103,9 @@ class FieldDescriptor: public Descriptor {
FieldDescriptor(Name* key,
int field_index,
PropertyAttributes attributes,
- Representation representation,
- int index = 0)
+ Representation representation)
: Descriptor(key, Smi::FromInt(field_index), attributes,
- FIELD, representation, index) {}
+ FIELD, representation) {}
};
@@ -120,10 +113,9 @@ class ConstantFunctionDescriptor: public Descriptor {
public:
ConstantFunctionDescriptor(Name* key,
JSFunction* function,
- PropertyAttributes attributes,
- int index)
- : Descriptor(key, function, attributes,
- CONSTANT_FUNCTION, Representation::Tagged(), index) {}
+ PropertyAttributes attributes)
+ : Descriptor(key, function, attributes, CONSTANT_FUNCTION,
+ Representation::Tagged()) {}
};
@@ -131,10 +123,9 @@ class CallbacksDescriptor: public Descriptor {
public:
CallbacksDescriptor(Name* key,
Object* foreign,
- PropertyAttributes attributes,
- int index = 0)
+ PropertyAttributes attributes)
: Descriptor(key, foreign, attributes, CALLBACKS,
- Representation::Tagged(), index) {}
+ Representation::Tagged()) {}
};
« no previous file with comments | « src/objects-inl.h ('k') | src/property.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698