components: Move PrefRegistrySyncable into user_prefs namespace.

components: Move PrefRegistrySyncable into user_prefs namespace.

BUG=180785
R=joi@chromium.org
TBR=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198384

[tfarina, 2013-05-04 19:18:59]

Here we go!! :)

vim integration with clang-format was really helpful here.

I'll fix any trybots issues as they come.

Thanks!

[Jói, 2013-05-04 21:31:47]

Thanks Thiago, great stuff.  If you'd prefer to address the issue I mention
about .cc files below in a follow-up patch, then LGTM for this patch apart from
the one nit about formatting.

Cheers,
Jói

https://codereview.chromium.org/14622003/diff/1/chrome/browser/bookmarks/book...
File chrome/browser/bookmarks/bookmark_prompt_prefs.cc (right):

https://codereview.chromium.org/14622003/diff/1/chrome/browser/bookmarks/book...
chrome/browser/bookmarks/bookmark_prompt_prefs.cc:37:
user_prefs::PrefRegistrySyncable* registry) {
For .cc files where there are more than one or two usages of
user_prefs::PrefRegistrySyncable, I would suggest a using declaration near the
top of the file, similar to what is commonly done for e.g.
content::BrowserThread.

For places where there are just a handful of usages, it's a judgment call, so up
to you whether to change this file for instance.

https://codereview.chromium.org/14622003/diff/1/chrome/browser/chromeos/proxy...
File chrome/browser/chromeos/proxy_config_service_impl.h (right):

https://codereview.chromium.org/14622003/diff/1/chrome/browser/chromeos/proxy...
chrome/browser/chromeos/proxy_config_service_impl.h:39: class
ProxyConfigServiceImpl: public PrefProxyConfigTrackerImpl,
space before :

https://codereview.chromium.org/14622003/diff/1/chrome/browser/content_settin...
File chrome/browser/content_settings/content_settings_policy_provider.cc
(right):

https://codereview.chromium.org/14622003/diff/1/chrome/browser/content_settin...
chrome/browser/content_settings/content_settings_policy_provider.cc:121:
user_prefs::PrefRegistrySyncable* registry) {
This is an example of a file where a using statement near the top of the file
would help a lot.

[tfarina, 2013-05-05 00:45:59]

Just waiting for the tree to open to land this, to avoid pain merges. :/

https://codereview.chromium.org/14622003/diff/1/chrome/browser/bookmarks/book...
File chrome/browser/bookmarks/bookmark_prompt_prefs.cc (right):

https://codereview.chromium.org/14622003/diff/1/chrome/browser/bookmarks/book...
chrome/browser/bookmarks/bookmark_prompt_prefs.cc:37:
user_prefs::PrefRegistrySyncable* registry) {
On 2013/05/04 21:31:47, Jói wrote:
> For .cc files where there are more than one or two usages of
> user_prefs::PrefRegistrySyncable, I would suggest a using declaration near the
> top of the file, similar to what is commonly done for e.g.
> content::BrowserThread.
> 
> For places where there are just a handful of usages, it's a judgment call, so
up
> to you whether to change this file for instance.
I'm going with user_prefs:: for now because it was easier for me that way to see
if I was missing something. I'll look into using "using
user_prefs::PrefRegistrySyncable;" in a follow up CL.

https://codereview.chromium.org/14622003/diff/1/chrome/browser/chromeos/proxy...
File chrome/browser/chromeos/proxy_config_service_impl.h (right):

https://codereview.chromium.org/14622003/diff/1/chrome/browser/chromeos/proxy...
chrome/browser/chromeos/proxy_config_service_impl.h:39: class
ProxyConfigServiceImpl: public PrefProxyConfigTrackerImpl,
On 2013/05/04 21:31:47, Jói wrote:
> space before :

Done.

https://codereview.chromium.org/14622003/diff/1/chrome/browser/content_settin...
File chrome/browser/content_settings/content_settings_policy_provider.cc
(right):

https://codereview.chromium.org/14622003/diff/1/chrome/browser/content_settin...
chrome/browser/content_settings/content_settings_policy_provider.cc:121:
user_prefs::PrefRegistrySyncable* registry) {
On 2013/05/04 21:31:47, Jói wrote:
> This is an example of a file where a using statement near the top of the file
> would help a lot.
Agreed! ;)

[tfarina, 2013-05-06 03:08:57]

TBRing Darin for this.

I was going to land this manually during the weekend to avoid conflicts but the
tree stayed closed.

CQing...

[commit-bot: I haz the power, 2013-05-06 03:09:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/14622003/10001

[commit-bot: I haz the power, 2013-05-06 06:17:38]

Change committed as 198384

[darin (slow to review), 2013-05-06 16:55:36]

rubber stamp LGTM