Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 14622003: components: Move PrefRegistrySyncable into user_prefs namespace. (Closed)

Created:
7 years, 7 months ago by tfarina
Modified:
7 years, 7 months ago
CC:
chromium-reviews, asanka, sadrul, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, ahutter, browser-components-watch_chromium.org, gideonwald, stuartmorgan+watch_chromium.org, dmazzoni+watch_chromium.org, Albert Bodenhamer, markusheintz_, benjhayden+dwatch_chromium.org, stevenjb+watch_chromium.org, cbentzel+watch_chromium.org, vsevik, melevin+watch_chromium.org, Aaron Boodman, aboxhall+watch_chromium.org, Ilya Sherman, jam, dbeam+watch-autofill_chromium.org, dominich, sail+watch_chromium.org, Raghu Simha, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, rpetterson, tim (not reviewing), pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, dtseng+watch_chromium.org, yoshiki+watch_chromium.org, rouslan+spellwatch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, samarth+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, kmadhusu+watch_chromium.org, Raman Kakilate, haitaol1, ctguil+watch_chromium.org, pfeldman, Jered, zork+watch_chromium.org, akalin, hashimoto+watch_chromium.org, tfarina, ben+watch_chromium.org, sreeram, yurys, davidbarr+watch_chromium.org, benquan, David Black, Dane Wallinga, dyu1, estade+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

components: Move PrefRegistrySyncable into user_prefs namespace. BUG=180785 R=joi@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198384

Patch Set 1 #

Total comments: 6

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2320 lines, -1610 lines) Patch
M chrome/browser/accessibility/invert_bubble_prefs.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/accessibility/invert_bubble_prefs.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/autofill/autofill_external_delegate_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_contents_service_factory.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_prompt_prefs.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_prompt_prefs.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 chunk +13 lines, -10 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +13 lines, -10 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/language_preferences.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/language_preferences.cc View 19 chunks +40 lines, -40 lines 0 comments Download
M chrome/browser/chromeos/login/oauth2_login_manager.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/oauth2_login_manager.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 5 chunks +219 lines, -166 lines 0 comments Download
M chrome/browser/chromeos/preferences_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl.h View 1 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider.cc View 1 chunk +48 lines, -39 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/cookie_settings.h View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/content_settings/cookie_settings.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.h View 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 chunk +14 lines, -10 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/devtools/devtools_window.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 3 chunks +22 lines, -15 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/download/download_prefs.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/download/download_prefs.cc View 1 chunk +22 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service_new.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/component_loader.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M chrome/browser/extensions/component_loader_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/default_apps.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/default_apps.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 chunk +49 lines, -38 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.h View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/test_extension_prefs.h View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/test_extension_prefs.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
chrome/browser/geolocation/chrome_geolocation_permission_context_factory.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/google/google_url_tracker_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google/google_url_tracker_factory.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service.cc View 1 chunk +20 lines, -14 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/http_server_properties_manager.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/net/http_server_properties_manager.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/net/net_pref_observer.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/net/net_pref_observer.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M chrome/browser/net/predictor.h View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 3 chunks +5 lines, -2 lines 0 comments Download
chrome/browser/notifications/desktop_notification_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_generation_manager.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_generation_manager.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_manager.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 chunk +11 lines, -8 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_store_x.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_x.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/pepper_flash_settings_manager.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/pepper_flash_settings_manager.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs_factory.cc View 1 chunk +23 lines, -18 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_factory.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_factory.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/policy/profile_policy_connector_factory.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/policy/url_blacklist_manager.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/policy/url_blacklist_manager.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 1 chunk +11 lines, -8 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/prefs/pref_service_mock_builder.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/prefs/pref_service_mock_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_syncable.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/prefs/pref_service_syncable.cc View 5 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/prefs/pref_service_syncable_builder.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_service_syncable_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/scoped_user_pref_update_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/session_startup_pref.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref.cc View 1 chunk +11 lines, -8 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref_unittest.cc View 6 chunks +25 lines, -15 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_url.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_url.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/profiles/chrome_version_service.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/profiles/chrome_version_service.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service_factory.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service_factory.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 2 chunks +65 lines, -48 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +56 lines, -42 lines 0 comments Download
M chrome/browser/profiles/profile_keyed_base_factory.h View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_keyed_base_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/pepper/device_id_fetcher.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/pepper/device_id_fetcher.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/browser/search/search.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/search/search.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 chunk +14 lines, -11 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.cc View 1 chunk +44 lines, -34 lines 0 comments Download
M chrome/browser/signin/about_signin_internals_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/about_signin_internals_factory.cc View 3 chunks +20 lines, -9 lines 0 comments Download
M chrome/browser/signin/signin_manager_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_manager_factory.cc View 1 chunk +19 lines, -12 lines 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_preferences.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_preferences.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_factory.cc View 1 chunk +18 lines, -14 lines 0 comments Download
M chrome/browser/sync/invalidations/invalidator_storage.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/invalidations/invalidator_storage.cc View 1 chunk +14 lines, -10 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_prefs.h View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_prefs.cc View 4 chunks +46 lines, -34 lines 0 comments Download
chrome/browser/themes/theme_service_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/themes/theme_service_factory.cc View 1 chunk +26 lines, -18 lines 0 comments Download
M chrome/browser/translate/translate_prefs.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_prefs.cc View 1 chunk +13 lines, -9 lines 0 comments Download
M chrome/browser/ui/alternate_error_tab_observer.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/alternate_error_tab_observer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.cc View 1 chunk +23 lines, -18 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_ui_prefs.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_ui_prefs.cc View 3 chunks +162 lines, -121 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/window_size_autosaver_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gesture_prefs_observer_factory_aura.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gesture_prefs_observer_factory_aura.cc View 2 chunks +46 lines, -43 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 3 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/network_profile_bubble.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/network_profile_bubble.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 6 chunks +170 lines, -127 lines 0 comments Download
M chrome/browser/ui/startup/autolaunch_prompt.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/autolaunch_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/autolaunch_prompt_win.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_codec.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_codec.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/instant_ui.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/instant_ui.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/android/promo_handler.h View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/ntp/android/promo_handler.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/foreign_session_handler.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/foreign_session_handler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_page_handler.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_page_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/plugins_ui.h View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/sticky_settings.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/sticky_settings.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc View 1 chunk +14 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 1 chunk +14 lines, -7 lines 0 comments Download
M chrome/browser/web_resource/notification_promo.h View 2 chunks +6 lines, -3 lines 0 comments Download
chrome/browser/web_resource/notification_promo.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/test/base/testing_pref_service_syncable.h View 1 chunk +17 lines, -16 lines 0 comments Download
M chrome/test/base/testing_pref_service_syncable.cc View 3 chunks +31 lines, -30 lines 0 comments Download
M components/autofill/browser/autofill_manager.h View 3 chunks +5 lines, -2 lines 0 comments Download
M components/autofill/browser/autofill_manager.cc View 1 chunk +22 lines, -16 lines 0 comments Download
M components/user_prefs/pref_registry_syncable.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/user_prefs/pref_registry_syncable.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Here we go!! :) vim integration with clang-format was really helpful here. I'll fix any ...
7 years, 7 months ago (2013-05-04 19:18:59 UTC) #1
Jói
Thanks Thiago, great stuff. If you'd prefer to address the issue I mention about .cc ...
7 years, 7 months ago (2013-05-04 21:31:47 UTC) #2
tfarina
Just waiting for the tree to open to land this, to avoid pain merges. :/ ...
7 years, 7 months ago (2013-05-05 00:45:59 UTC) #3
tfarina
TBRing Darin for this. I was going to land this manually during the weekend to ...
7 years, 7 months ago (2013-05-06 03:08:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/14622003/10001
7 years, 7 months ago (2013-05-06 03:09:19 UTC) #5
commit-bot: I haz the power
Change committed as 198384
7 years, 7 months ago (2013-05-06 06:17:38 UTC) #6
darin (slow to review)
7 years, 7 months ago (2013-05-06 16:55:36 UTC) #7
Message was sent while issue was closed.
rubber stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698