Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: chrome/browser/sync/invalidations/invalidator_storage.h

Issue 14622003: components: Move PrefRegistrySyncable into user_prefs namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Wraps PrefService in an InvalidationStateTracker to allow SyncNotifiers 5 // Wraps PrefService in an InvalidationStateTracker to allow SyncNotifiers
6 // to use PrefService as persistence for invalidation state. It is not thread 6 // to use PrefService as persistence for invalidation state. It is not thread
7 // safe, and lives on the UI thread. 7 // safe, and lives on the UI thread.
8 8
9 #ifndef CHROME_BROWSER_SYNC_INVALIDATIONS_INVALIDATOR_STORAGE_H_ 9 #ifndef CHROME_BROWSER_SYNC_INVALIDATIONS_INVALIDATOR_STORAGE_H_
10 #define CHROME_BROWSER_SYNC_INVALIDATIONS_INVALIDATOR_STORAGE_H_ 10 #define CHROME_BROWSER_SYNC_INVALIDATIONS_INVALIDATOR_STORAGE_H_
11 11
12 #include "base/basictypes.h" 12 #include "base/basictypes.h"
13 #include "base/gtest_prod_util.h" 13 #include "base/gtest_prod_util.h"
14 #include "base/memory/weak_ptr.h" 14 #include "base/memory/weak_ptr.h"
15 #include "base/threading/thread_checker.h" 15 #include "base/threading/thread_checker.h"
16 #include "sync/notifier/invalidation_state_tracker.h" 16 #include "sync/notifier/invalidation_state_tracker.h"
17 17
18 class PrefService; 18 class PrefService;
19 class PrefRegistrySyncable;
20 19
21 namespace base { 20 namespace base {
22 class DictionaryValue; 21 class DictionaryValue;
23 class ListValue; 22 class ListValue;
24 } 23 }
25 24
25 namespace user_prefs {
26 class PrefRegistrySyncable;
27 }
28
26 namespace browser_sync { 29 namespace browser_sync {
27 30
28 // TODO(tim): Bug 124137. We may want to move this outside of sync/ into a 31 // TODO(tim): Bug 124137. We may want to move this outside of sync/ into a
29 // browser/invalidations directory, or re-organize to have a browser 32 // browser/invalidations directory, or re-organize to have a browser
30 // subdirectory that contains signin/ sync/ invalidations/ and other cloud 33 // subdirectory that contains signin/ sync/ invalidations/ and other cloud
31 // services. For now this is still tied to sync while we refactor, so minimize 34 // services. For now this is still tied to sync while we refactor, so minimize
32 // churn and keep it here. 35 // churn and keep it here.
33 class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>, 36 class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>,
34 public syncer::InvalidationStateTracker { 37 public syncer::InvalidationStateTracker {
35 public: 38 public:
36 static void RegisterUserPrefs(PrefRegistrySyncable* registry); 39 static void RegisterUserPrefs(user_prefs::PrefRegistrySyncable* registry);
37 40
38 // |pref_service| may be NULL (for unit tests), but in that case no setter 41 // |pref_service| may be NULL (for unit tests), but in that case no setter
39 // methods should be called. Does not own |pref_service|. 42 // methods should be called. Does not own |pref_service|.
40 explicit InvalidatorStorage(PrefService* pref_service); 43 explicit InvalidatorStorage(PrefService* pref_service);
41 virtual ~InvalidatorStorage(); 44 virtual ~InvalidatorStorage();
42 45
43 // InvalidationStateTracker implementation. 46 // InvalidationStateTracker implementation.
44 virtual syncer::InvalidationStateMap GetAllInvalidationStates() const 47 virtual syncer::InvalidationStateMap GetAllInvalidationStates() const
45 OVERRIDE; 48 OVERRIDE;
46 virtual void SetMaxVersionAndPayload(const invalidation::ObjectId& id, 49 virtual void SetMaxVersionAndPayload(const invalidation::ObjectId& id,
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 100
98 // May be NULL. 101 // May be NULL.
99 PrefService* const pref_service_; 102 PrefService* const pref_service_;
100 103
101 DISALLOW_COPY_AND_ASSIGN(InvalidatorStorage); 104 DISALLOW_COPY_AND_ASSIGN(InvalidatorStorage);
102 }; 105 };
103 106
104 } // namespace browser_sync 107 } // namespace browser_sync
105 108
106 #endif // CHROME_BROWSER_SYNC_INVALIDATIONS_INVALIDATOR_STORAGE_H_ 109 #endif // CHROME_BROWSER_SYNC_INVALIDATIONS_INVALIDATOR_STORAGE_H_
OLDNEW
« no previous file with comments | « chrome/browser/spellchecker/spellcheck_factory.cc ('k') | chrome/browser/sync/invalidations/invalidator_storage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698