Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 14619029: DevTools [Canvas Profile] Fix CanvasProfile control button issue (Closed)

Created:
7 years, 7 months ago by Pan
Modified:
7 years, 6 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools [Canvas Profile] Fix CanvasProfile control button issue Canvas profiler control button should be "Take Snapshot" in Single Frame mode. Contributed by pan.deng@intel.com BUG=239739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M Source/devtools/front_end/CanvasProfileView.js View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ProfileLauncherView.js View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ProfilesPanel.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Pan
Ready to review :) thanks! Pan
7 years, 7 months ago (2013-05-10 07:05:06 UTC) #1
Pan
@yurys, could you please help review this? :) thanks! Pan
7 years, 7 months ago (2013-05-23 05:16:06 UTC) #2
yurys
@aandrey: could you take a look at this?
7 years, 7 months ago (2013-05-23 16:58:03 UTC) #3
aandrey
lgtm
7 years, 7 months ago (2013-05-24 08:00:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/14619029/1
7 years, 7 months ago (2013-05-24 08:11:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=525
7 years, 7 months ago (2013-05-24 08:22:08 UTC) #6
Pan
thanks aandrey, :) in addition, @yurys, vsevik and Pavel, your grant is needed to land ...
7 years, 7 months ago (2013-05-24 09:06:24 UTC) #7
yurys
lgtm
7 years, 7 months ago (2013-05-24 16:30:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/14619029/1
7 years, 7 months ago (2013-05-24 22:29:52 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10198
7 years, 7 months ago (2013-05-24 23:19:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/14619029/1
7 years, 7 months ago (2013-05-25 03:18:54 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10242
7 years, 7 months ago (2013-05-25 04:00:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/14619029/1
7 years, 7 months ago (2013-05-27 16:43:28 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6888
7 years, 7 months ago (2013-05-27 18:28:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/14619029/1
7 years, 7 months ago (2013-05-28 01:11:10 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6955
7 years, 7 months ago (2013-05-28 03:29:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/14619029/1
7 years, 6 months ago (2013-05-28 07:20:47 UTC) #17
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 07:55:05 UTC) #18
Message was sent while issue was closed.
Change committed as 151221

Powered by Google App Engine
This is Rietveld 408576698