Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 14619019: Move compositor support out of base WebKitPlatformSupport into renderer (Closed)

Created:
7 years, 7 months ago by jamesr
Modified:
7 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move compositor support out of base WebKitPlatformSupport into renderer WebCompositorSupport is a tear-off of WebKit::Platform that provides WebKit with access to compositing classes. This is only needed by renderers and by DumpRenderTree+webkit_unit_tests. Having it linked in to the base chromium implementation of WebKit::Platform pulled the compositor support into every embedding of WebKit, including browser process embeddings, unnecessarily. BUG=237267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199318

Patch Set 1 #

Patch Set 2 : Remove more refs #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M content/content_renderer.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/unittest_test_suite.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.h View 1 4 chunks +0 lines, -7 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
PTAL.
7 years, 7 months ago (2013-05-09 18:30:55 UTC) #1
piman
On 2013/05/09 18:30:55, jamesr wrote: > PTAL. LGTM, but can you double-check we're not implicitly ...
7 years, 7 months ago (2013-05-09 18:43:41 UTC) #2
jamesr
Removed a bit more (forward declaration in webkit/glue and the content_unittests harness). git grep can't ...
7 years, 7 months ago (2013-05-09 19:59:13 UTC) #3
piman
lgtm
7 years, 7 months ago (2013-05-09 20:04:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/14619019/5011
7 years, 7 months ago (2013-05-09 20:50:24 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 01:00:01 UTC) #6
Message was sent while issue was closed.
Change committed as 199318

Powered by Google App Engine
This is Rietveld 408576698