Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 14587002: Add DefaultNetworkChanged signal for ConnectivityStateHelper observers (Closed)

Created:
7 years, 7 months ago by gauravsh
Modified:
7 years, 7 months ago
Reviewers:
stevenjb, ygorshenin1
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add DefaultNetworkChanged signal for ConnectivityStateHelper observers NetworkLibrary's OnNetworkManagerChanged signal is generated even for changes on the default network (without a corresponding change on the NetworkManager). Many consumers (e.g. NetworkScreen) rely on this behavior to not miss connectivity state updates. Add an explicit DefaultNetworkChanged signal for ConnectivityStateHelper observers to get signaled for such events when using the NetworkStateHandler based implementation (which is the default now). BUG=236417 TEST=1) Start in OOBE state (no Shill default profile, no Chrome local state). 2) Observer "Continue" button is grayed out. 3) Choose a wireless network (say "GoogleGuest") 4) "Continue" button should be come enabled now. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/net/connectivity_state_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/connectivity_state_helper.cc View 4 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/net/connectivity_state_helper_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gauravsh
stevenjb: For ConnectivityStateHelper changes ygorshenin: For network_screen*.* changes An alternative though equivalent implementation is to ...
7 years, 7 months ago (2013-04-30 02:15:35 UTC) #1
ygorshenin1
lgtm
7 years, 7 months ago (2013-04-30 07:43:00 UTC) #2
stevenjb
lgtm
7 years, 7 months ago (2013-04-30 18:35:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/14587002/1
7 years, 7 months ago (2013-04-30 18:40:05 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-04-30 21:23:45 UTC) #5
Message was sent while issue was closed.
Change committed as 197475

Powered by Google App Engine
This is Rietveld 408576698