Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Side by Side Diff: chrome/browser/chromeos/net/connectivity_state_helper.cc

Issue 14587002: Add DefaultNetworkChanged signal for ConnectivityStateHelper observers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/net/connectivity_state_helper.h" 5 #include "chrome/browser/chromeos/net/connectivity_state_helper.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/browser/chromeos/cros/cros_library.h" 8 #include "chrome/browser/chromeos/cros/cros_library.h"
9 #include "chrome/browser/chromeos/cros/network_library.h" 9 #include "chrome/browser/chromeos/cros/network_library.h"
10 #include "chromeos/chromeos_switches.h" 10 #include "chromeos/chromeos_switches.h"
(...skipping 21 matching lines...) Expand all
32 virtual bool IsConnecting() OVERRIDE; 32 virtual bool IsConnecting() OVERRIDE;
33 virtual bool IsConnectedType(const std::string& type) OVERRIDE; 33 virtual bool IsConnectedType(const std::string& type) OVERRIDE;
34 virtual bool IsConnectingType(const std::string& type) OVERRIDE; 34 virtual bool IsConnectingType(const std::string& type) OVERRIDE;
35 virtual std::string NetworkNameForType(const std::string& type) OVERRIDE; 35 virtual std::string NetworkNameForType(const std::string& type) OVERRIDE;
36 virtual std::string DefaultNetworkName() OVERRIDE; 36 virtual std::string DefaultNetworkName() OVERRIDE;
37 virtual bool DefaultNetworkOnline() OVERRIDE; 37 virtual bool DefaultNetworkOnline() OVERRIDE;
38 virtual void RequestScan() const OVERRIDE; 38 virtual void RequestScan() const OVERRIDE;
39 39
40 // NetworkStateHandlerObserver overrides. 40 // NetworkStateHandlerObserver overrides.
41 virtual void NetworkManagerChanged() OVERRIDE; 41 virtual void NetworkManagerChanged() OVERRIDE;
42 virtual void DefaultNetworkChanged(const NetworkState* network) OVERRIDE;
42 43
43 private: 44 private:
44 NetworkStateHandler* network_state_handler_; 45 NetworkStateHandler* network_state_handler_;
45 }; 46 };
46 47
47 // Implementation of the connectivity state helper that uses the network 48 // Implementation of the connectivity state helper that uses the network
48 // library for fetching connectivity state. 49 // library for fetching connectivity state.
49 class ConnectivityStateHelperNetworkLibrary 50 class ConnectivityStateHelperNetworkLibrary
50 : public ConnectivityStateHelper, 51 : public ConnectivityStateHelper,
51 public NetworkLibrary::NetworkManagerObserver { 52 public NetworkLibrary::NetworkManagerObserver {
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 } 111 }
111 112
112 // static 113 // static
113 void ConnectivityStateHelper::SetForTest(ConnectivityStateHelper* impl) { 114 void ConnectivityStateHelper::SetForTest(ConnectivityStateHelper* impl) {
114 CHECK(!g_test_connectivity_state_helper || !impl); 115 CHECK(!g_test_connectivity_state_helper || !impl);
115 g_test_connectivity_state_helper = impl; 116 g_test_connectivity_state_helper = impl;
116 } 117 }
117 118
118 void ConnectivityStateHelper::AddNetworkManagerObserver( 119 void ConnectivityStateHelper::AddNetworkManagerObserver(
119 ConnectivityStateHelperObserver* observer) { 120 ConnectivityStateHelperObserver* observer) {
120 network_manager_observers_.AddObserver(observer); 121 connectivity_observers_.AddObserver(observer);
121 } 122 }
122 123
123 void ConnectivityStateHelper::RemoveNetworkManagerObserver( 124 void ConnectivityStateHelper::RemoveNetworkManagerObserver(
124 ConnectivityStateHelperObserver* observer) { 125 ConnectivityStateHelperObserver* observer) {
125 network_manager_observers_.RemoveObserver(observer); 126 connectivity_observers_.RemoveObserver(observer);
126 } 127 }
127 128
128 ConnectivityStateHelperImpl::ConnectivityStateHelperImpl() { 129 ConnectivityStateHelperImpl::ConnectivityStateHelperImpl() {
129 network_state_handler_ = NetworkStateHandler::Get(); 130 network_state_handler_ = NetworkStateHandler::Get();
130 network_state_handler_->AddObserver(this); 131 network_state_handler_->AddObserver(this);
131 } 132 }
132 133
133 ConnectivityStateHelperImpl::~ConnectivityStateHelperImpl() { 134 ConnectivityStateHelperImpl::~ConnectivityStateHelperImpl() {
134 NetworkStateHandler::Get()->RemoveObserver(this); 135 NetworkStateHandler::Get()->RemoveObserver(this);
135 } 136 }
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 if (network->connection_state() == flimflam::kStatePortal) 179 if (network->connection_state() == flimflam::kStatePortal)
179 return false; 180 return false;
180 return true; 181 return true;
181 } 182 }
182 183
183 void ConnectivityStateHelperImpl::RequestScan() const { 184 void ConnectivityStateHelperImpl::RequestScan() const {
184 network_state_handler_->RequestScan(); 185 network_state_handler_->RequestScan();
185 } 186 }
186 187
187 void ConnectivityStateHelperImpl::NetworkManagerChanged() { 188 void ConnectivityStateHelperImpl::NetworkManagerChanged() {
188 FOR_EACH_OBSERVER(ConnectivityStateHelperObserver, network_manager_observers_, 189 FOR_EACH_OBSERVER(ConnectivityStateHelperObserver, connectivity_observers_,
189 NetworkManagerChanged()); 190 NetworkManagerChanged());
190 } 191 }
191 192
193 void ConnectivityStateHelperImpl::DefaultNetworkChanged(
194 const NetworkState* network) {
195 FOR_EACH_OBSERVER(ConnectivityStateHelperObserver, connectivity_observers_,
196 DefaultNetworkChanged());
197 }
198
192 //////////////////////////////////////////////////////////////////////////////// 199 ////////////////////////////////////////////////////////////////////////////////
193 // NetworkLibrary implementation. 200 // NetworkLibrary implementation.
194 // 201 //
195 202
196 ConnectivityStateHelperNetworkLibrary::ConnectivityStateHelperNetworkLibrary() { 203 ConnectivityStateHelperNetworkLibrary::ConnectivityStateHelperNetworkLibrary() {
197 network_library_ = CrosLibrary::Get()->GetNetworkLibrary(); 204 network_library_ = CrosLibrary::Get()->GetNetworkLibrary();
198 network_library_->AddNetworkManagerObserver(this); 205 network_library_->AddNetworkManagerObserver(this);
199 } 206 }
200 207
201 ConnectivityStateHelperNetworkLibrary::~ConnectivityStateHelperNetworkLibrary() 208 ConnectivityStateHelperNetworkLibrary::~ConnectivityStateHelperNetworkLibrary()
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 return false; 273 return false;
267 return true; 274 return true;
268 } 275 }
269 276
270 void ConnectivityStateHelperNetworkLibrary::RequestScan() const { 277 void ConnectivityStateHelperNetworkLibrary::RequestScan() const {
271 network_library_->RequestNetworkScan(); 278 network_library_->RequestNetworkScan();
272 } 279 }
273 280
274 void ConnectivityStateHelperNetworkLibrary::OnNetworkManagerChanged( 281 void ConnectivityStateHelperNetworkLibrary::OnNetworkManagerChanged(
275 NetworkLibrary* network_library) { 282 NetworkLibrary* network_library) {
276 FOR_EACH_OBSERVER(ConnectivityStateHelperObserver, network_manager_observers_, 283 FOR_EACH_OBSERVER(ConnectivityStateHelperObserver, connectivity_observers_,
277 NetworkManagerChanged()); 284 NetworkManagerChanged());
278 } 285 }
279 286
280 } // namespace chromeos 287 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698