Issue 14581006: [cros mp] Load profiles from /home/chronos/u-[$hash], add GetUserIdHashFromProfile()

Issue 14581006: [cros mp] Load profiles from /home/chronos/u-[$hash], add GetUserIdHashFromProfile() (Closed)

Created:
7 years, 7 months ago by Nikita (slow)

Modified:
7 years, 7 months ago

Reviewers:
Dmitry Polukhin, satorux1, sail, zel, pneubeck (no reviews)

CC:
chromium-reviews, nkostylev+watch_chromium.org, sail+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros mp] Load profiles from /home/chronos/u-[$hash], add GetUserIdHashFromProfile() * KioskTest.InstallAndLaunchApp will fail when --multi-profiles switch is passed. Kiosk MP auth flow support is tracked at http://crbug.com/238985 BUG=238623, 229411 TBR=pneubeck Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199434

Patch Set 1 #

Patch Set 2 : cl #

Patch Set 3 : test #

Patch Set 4 : fix ExtensionNetworkingPrivateApiTest #

Patch Set 5 : ProfileHelper - check for non-empty user_id_hash only with --multi-profiles switch #

Total comments: 2

Patch Set 6 : reference bugs in TODO #

Patch Set 7 : use ProfileHelper function in networking_private_api #

Patch Set 8 : networking_private_api - use user_id_hash only if --multi-profiles switch is passed #

Total comments: 2

Patch Set 9 : merge #

Patch Set 10 : fix #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -45 lines)			Patch
M	chrome/browser/chromeos/app_mode/kiosk_app_launcher.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/networking_private_api.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+15 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/networking_private_apitest.cc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/profiles/profile_helper.h	View	1 2 3 4 5 6 7 8	5 chunks	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/profiles/profile_helper.cc	View	1 2 3 4 5 6 7 8	6 chunks	+41 lines, -10 lines	0 comments	Download
A	chrome/browser/chromeos/profiles/profile_helper_browsertest.cc	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.cc	View		4 chunks	+3 lines, -25 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/dbus/cryptohome_client.cc	View	1 2 3	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 15 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

dpolukhin@ - please review chrome/browser/chromeos/profiles/* sail@ - please review chrome/browser/profiles/profile_manager.cc satorux@ for owner review of ...

7 years, 7 months ago (2013-05-07 15:43:47 UTC) #1

Dmitry Polukhin

LGTM https://codereview.chromium.org/14581006/diff/17002/chrome/browser/chromeos/profiles/profile_helper.h File chrome/browser/chromeos/profiles/profile_helper.h (right): https://codereview.chromium.org/14581006/diff/17002/chrome/browser/chromeos/profiles/profile_helper.h#newcode20 chrome/browser/chromeos/profiles/profile_helper.h:20: // Chrome OS profile directories have custom prefix. ...

7 years, 7 months ago (2013-05-08 09:51:39 UTC) #3

Nikita (slow)

https://codereview.chromium.org/14581006/diff/17002/chrome/browser/chromeos/profiles/profile_helper.h File chrome/browser/chromeos/profiles/profile_helper.h (right): https://codereview.chromium.org/14581006/diff/17002/chrome/browser/chromeos/profiles/profile_helper.h#newcode20 chrome/browser/chromeos/profiles/profile_helper.h:20: // Chrome OS profile directories have custom prefix. On ...

7 years, 7 months ago (2013-05-08 11:10:01 UTC) #4

Nikita (slow)

+pneubeck@ - please review chrome/browser/chromeos/extensions/* +zelidrag@ - owner review for chrome/browser/chromeos/extensions/*

7 years, 7 months ago (2013-05-08 11:27:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/14581006/22001

7 years, 7 months ago (2013-05-08 16:54:14 UTC) #8

pneubeck (no reviews)

https://codereview.chromium.org/14581006/diff/22001/chrome/browser/chromeos/extensions/networking_private_api.cc File chrome/browser/chromeos/extensions/networking_private_api.cc (right): https://codereview.chromium.org/14581006/diff/22001/chrome/browser/chromeos/extensions/networking_private_api.cc#newcode113 chrome/browser/chromeos/extensions/networking_private_api.cc:113: } The else case should fallback on active_user_id_hash(), I'd ...

7 years, 7 months ago (2013-05-08 17:55:26 UTC) #9

Nikita (slow)

Active user ID hash could be empty for guest session and restart after crash cases ...

7 years, 7 months ago (2013-05-08 18:06:31 UTC) #10

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=38138

7 years, 7 months ago (2013-05-08 23:56:22 UTC) #11

Nikita (slow)

https://codereview.chromium.org/14581006/diff/22001/chrome/browser/chromeos/extensions/networking_private_api.cc File chrome/browser/chromeos/extensions/networking_private_api.cc (right): https://codereview.chromium.org/14581006/diff/22001/chrome/browser/chromeos/extensions/networking_private_api.cc#newcode113 chrome/browser/chromeos/extensions/networking_private_api.cc:113: } On 2013/05/08 17:55:26, pneubeck wrote: > The else ...

7 years, 7 months ago (2013-05-09 20:00:54 UTC) #12

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/14581006/48001

7 years, 7 months ago (2013-05-10 06:25:10 UTC) #13

Message was sent while issue was closed.

Change committed as 199434

Expand Messages | Collapse Messages