Don't display drop down arrows in rAc dialog unless there is a suggestion

Don't display drop down arrows in rAc dialog unless there is a suggestion

BUG=235222
R=aruslan@chromium.org, dbeam@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198157

[Dan Beam, 2013-04-30 02:16:48]

lg but can haz test?

[Evan Stade, 2013-04-30 16:16:02]

Yes you can

[Evan Stade, 2013-04-30 16:16:49]

+aruslan for android.

[aruslan, 2013-04-30 16:37:28]

https://codereview.chromium.org/14571003/diff/15001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/14571003/diff/15001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:702: return NULL;
On Android the editing form is shown only when the user asked to Add/Edit a
section value.
The "steady" state of the dialog has all sections collapsed and showing the
selected value.

To avoid breakage on Android, please keep returning the valid set of items for
Android till the UI issue is resolved.

[Evan Stade, 2013-04-30 18:25:56]

On 2013/04/30 16:37:28, aruslan wrote:
>
https://codereview.chromium.org/14571003/diff/15001/chrome/browser/ui/autofil...
> File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):
> 
>
https://codereview.chromium.org/14571003/diff/15001/chrome/browser/ui/autofil...
> chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:702: return
NULL;
> On Android the editing form is shown only when the user asked to Add/Edit a
> section value.
> The "steady" state of the dialog has all sections collapsed and showing the
> selected value.
> 
> To avoid breakage on Android, please keep returning the valid set of items for
> Android till the UI issue is resolved.

done.

[aruslan, 2013-04-30 18:30:32]

Android changes LGTM

[Dan Beam, 2013-04-30 18:52:40]

lgtm but I really wish the the *Hack() method didn't exist :(

[commit-bot: I haz the power, 2013-04-30 20:49:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/14571003/20001

[commit-bot: I haz the power, 2013-04-30 20:59:03]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[aruslan, 2013-04-30 21:46:56]

estade@ -- I guess there is one more to be changed. Thanks!

https://chromiumcodereview.appspot.com/14571003/diff/20001/chrome/browser/ui/...
File chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc (right):

https://chromiumcodereview.appspot.com/14571003/diff/20001/chrome/browser/ui/...
chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc:281:
controller_->MenuModelForSection(static_cast<DialogSection>(section));
Please change this as well.

[commit-bot: I haz the power, 2013-05-02 03:05:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/14571003/41001

[commit-bot: I haz the power, 2013-05-02 03:15:29]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Evan Stade, 2013-05-02 16:15:22]

+sky for views owner review

[sky, 2013-05-02 17:43:45]

LGTM

[commit-bot: I haz the power, 2013-05-02 22:47:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/14571003/41001

[commit-bot: I haz the power, 2013-05-03 04:40:07]

Retried try job too often on linux_chromeos for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Evan Stade, 2013-05-03 19:02:05]

Committed patchset #5 manually as r198157 (presubmit successful).