Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 14562007: Change TestResultServer to use python 2.7. (Closed)

Created:
7 years, 7 months ago by ojan
Modified:
7 years, 7 months ago
Reviewers:
Dirk Pranke, eseidel
CC:
blink-reviews, Julie Parent, mmontgomery, dglazkov
Visibility:
Public.

Description

Change TestResultServer to use python 2.7. -Allows us to have threadsafe handlers, so our server can handle concurrent requests. -Allows us to drop dependencies on django modules that no longer ship with the SDK. -Allows us to import json directly instead of simplejson out of django.utils. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149707

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -46 lines) Patch
M Tools/TestResultServer/app.yaml View 2 chunks +4 lines, -3 lines 0 comments Download
M Tools/TestResultServer/handlers/menu.py View 2 chunks +3 lines, -2 lines 1 comment Download
M Tools/TestResultServer/handlers/testfilehandler.py View 5 chunks +5 lines, -5 lines 0 comments Download
M Tools/TestResultServer/main.py View 2 chunks +2 lines, -14 lines 0 comments Download
M Tools/TestResultServer/model/datastorefile.py View 1 chunk +0 lines, -1 line 0 comments Download
M Tools/TestResultServer/model/jsonresults.py View 3 chunks +4 lines, -5 lines 0 comments Download
M Tools/TestResultServer/model/jsonresults_unittest.py View 5 chunks +15 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ojan
7 years, 7 months ago (2013-05-06 00:37:11 UTC) #1
ojan
I did some manual testing of all the basic commands. webapp2 seems like it's a ...
7 years, 7 months ago (2013-05-06 00:44:31 UTC) #2
eseidel
lgtm Yeah, I did this to a couple of my own GAE instances a few ...
7 years, 7 months ago (2013-05-06 03:12:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/14562007/1
7 years, 7 months ago (2013-05-06 03:12:11 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6774
7 years, 7 months ago (2013-05-06 03:52:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/14562007/1
7 years, 7 months ago (2013-05-06 04:04:23 UTC) #6
commit-bot: I haz the power
Change committed as 149707
7 years, 7 months ago (2013-05-06 04:26:28 UTC) #7
Dirk Pranke
lgtm too. https://codereview.chromium.org/14562007/diff/1/Tools/TestResultServer/handlers/menu.py File Tools/TestResultServer/handlers/menu.py (right): https://codereview.chromium.org/14562007/diff/1/Tools/TestResultServer/handlers/menu.py#newcode29 Tools/TestResultServer/handlers/menu.py:29: import webapp2 It's odd that there's no ...
7 years, 7 months ago (2013-05-06 19:10:44 UTC) #8
ojan
On 2013/05/06 19:10:44, Dirk Pranke wrote: > lgtm too. > > https://codereview.chromium.org/14562007/diff/1/Tools/TestResultServer/handlers/menu.py > File Tools/TestResultServer/handlers/menu.py ...
7 years, 7 months ago (2013-05-06 19:13:04 UTC) #9
ojan
7 years, 7 months ago (2013-05-06 21:28:03 UTC) #10
Message was sent while issue was closed.
Ugh. Had to rollback.

https://codereview.chromium.org/14833004

Powered by Google App Engine
This is Rietveld 408576698