Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14495011: Revert "Create errors (especially cancellation errors) internally to WebCore, rather" (Closed)

Created:
7 years, 7 months ago by Nate Chapin
Modified:
7 years, 7 months ago
CC:
blink-reviews, jamesr, abarth_chromum.org, gavinp+loader_chromium.org, jeez, jochen+watch_chromium.org
Visibility:
Public.

Description

Revert "Create errors (especially cancellation errors) internally to WebCore, rather" This reverts commit 2e0515922df0d78e12e68e117f2f76b372a1ab8a. TBR=darin BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -53 lines) Patch
M Source/Platform/Platform.gyp/Platform.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/Platform/chromium/public/Platform.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/Platform/chromium/src/Platform.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/WebKit/chromium/public/WebFrameClient.h View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/FrameLoaderClientImpl.h View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp View 5 chunks +61 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/WebFrameTest.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/html/PluginDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 10 chunks +21 lines, -11 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/core/loader/ResourceLoader.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/loader/ResourceLoader.cpp View 2 chunks +11 lines, -1 line 0 comments Download
M Source/core/page/ContextMenuController.cpp View 2 chunks +11 lines, -6 lines 0 comments Download
M Source/core/platform/network/ResourceError.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/network/ResourceError.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h View 3 chunks +18 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp View 2 chunks +28 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/WebViewHost.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/WebViewHost.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nate Chapin
This is showing additional compile errors, this time on win.
7 years, 7 months ago (2013-04-29 18:37:24 UTC) #1
Nate Chapin
Committed patchset #1 manually as r149351 (presubmit successful).
7 years, 7 months ago (2013-04-29 18:38:04 UTC) #2
darin (slow to review)
7 years, 7 months ago (2013-04-30 00:00:00 UTC) #3
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698