Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: Source/core/loader/ResourceLoader.cpp

Issue 14495011: Revert "Create errors (especially cancellation errors) internally to WebCore, rather" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/ResourceLoader.h ('k') | Source/core/page/ContextMenuController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2010, 2011 Apple Inc. All rights reserved.
3 * (C) 2007 Graham Dennis (graham.dennis@gmail.com) 3 * (C) 2007 Graham Dennis (graham.dennis@gmail.com)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 { 253 {
254 cancel(ResourceError()); 254 cancel(ResourceError());
255 } 255 }
256 256
257 void ResourceLoader::cancel(const ResourceError& error) 257 void ResourceLoader::cancel(const ResourceError& error)
258 { 258 {
259 // If the load has already completed - succeeded, failed, or previously canc elled - do nothing. 259 // If the load has already completed - succeeded, failed, or previously canc elled - do nothing.
260 if (m_reachedTerminalState) 260 if (m_reachedTerminalState)
261 return; 261 return;
262 262
263 ResourceError nonNullError = error.isNull() ? ResourceError::cancelledError( m_request.url()) : error; 263 ResourceError nonNullError = error.isNull() ? cancelledError() : error;
264 264
265 // This function calls out to clients at several points that might do 265 // This function calls out to clients at several points that might do
266 // something that causes the last reference to this object to go away. 266 // something that causes the last reference to this object to go away.
267 RefPtr<ResourceLoader> protector(this); 267 RefPtr<ResourceLoader> protector(this);
268 268
269 // If we re-enter cancel() from inside this if() block, we want to pick up f rom where we left 269 // If we re-enter cancel() from inside this if() block, we want to pick up f rom where we left
270 // off without re-running it 270 // off without re-running it
271 if (m_state == Initialized) { 271 if (m_state == Initialized) {
272 LOG(ResourceLoading, "Cancelled load of '%s'.\n", m_resource->url().stri ng().latin1().data()); 272 LOG(ResourceLoading, "Cancelled load of '%s'.\n", m_resource->url().stri ng().latin1().data());
273 m_state = Finishing; 273 m_state = Finishing;
(...skipping 21 matching lines...) Expand all
295 frameLoader()->notifier()->didFailToLoad(this, nonNullError); 295 frameLoader()->notifier()->didFailToLoad(this, nonNullError);
296 } 296 }
297 297
298 // If cancel() completed from within the call to willCancel() or didFailToLo ad(), 298 // If cancel() completed from within the call to willCancel() or didFailToLo ad(),
299 // we don't want to redo didCancel() or releasesResources(). 299 // we don't want to redo didCancel() or releasesResources().
300 if (m_reachedTerminalState) 300 if (m_reachedTerminalState)
301 return; 301 return;
302 releaseResources(); 302 releaseResources();
303 } 303 }
304 304
305 ResourceError ResourceLoader::cancelledError()
306 {
307 return frameLoader()->cancelledError(m_request);
308 }
309
310 ResourceError ResourceLoader::cannotShowURLError()
311 {
312 return frameLoader()->client()->cannotShowURLError(m_request);
313 }
314
305 void ResourceLoader::willSendRequest(ResourceHandle*, ResourceRequest& request, const ResourceResponse& redirectResponse) 315 void ResourceLoader::willSendRequest(ResourceHandle*, ResourceRequest& request, const ResourceResponse& redirectResponse)
306 { 316 {
307 if (documentLoader()->applicationCacheHost()->maybeLoadFallbackForRedirect(t his, request, redirectResponse)) 317 if (documentLoader()->applicationCacheHost()->maybeLoadFallbackForRedirect(t his, request, redirectResponse))
308 return; 318 return;
309 319
310 // Store the previous URL because we may modify it. 320 // Store the previous URL because we may modify it.
311 KURL previousURL = m_request.url(); 321 KURL previousURL = m_request.url();
312 RefPtr<ResourceLoader> protect(this); 322 RefPtr<ResourceLoader> protect(this);
313 323
314 ASSERT(!request.isNull()); 324 ASSERT(!request.isNull());
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 info.addMember(m_request, "request"); 530 info.addMember(m_request, "request");
521 info.addMember(m_originalRequest, "originalRequest"); 531 info.addMember(m_originalRequest, "originalRequest");
522 info.addMember(m_deferredRequest, "deferredRequest"); 532 info.addMember(m_deferredRequest, "deferredRequest");
523 info.addMember(m_options, "options"); 533 info.addMember(m_options, "options");
524 info.addMember(m_resource, "resource"); 534 info.addMember(m_resource, "resource");
525 info.addMember(m_documentLoader, "documentLoader"); 535 info.addMember(m_documentLoader, "documentLoader");
526 info.addMember(m_requestCountTracker, "requestCountTracker"); 536 info.addMember(m_requestCountTracker, "requestCountTracker");
527 } 537 }
528 538
529 } 539 }
OLDNEW
« no previous file with comments | « Source/core/loader/ResourceLoader.h ('k') | Source/core/page/ContextMenuController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698