Added the 'Translation Logs' tab to chrome://translate-internals/

chrome/renderer/translate/translate_helper.h

Index: chrome/renderer/translate/translate_helper.h
diff --git a/chrome/renderer/translate/translate_helper.h b/chrome/renderer/translate/translate_helper.h
index f0ae0d91bdb0062c5fe80710051963ba2707b9cc..e83dcbb0db52b5bf894aa106e6f5aae99fa86e1e 100644
--- a/chrome/renderer/translate/translate_helper.h
+++ b/chrome/renderer/translate/translate_helper.h
@@ -108,7 +108,9 @@ class TranslateHelper : public content::RenderViewObserver {
 
   // Determine content page language from Content-Language code and contents.
   static std::string DeterminePageLanguage(const std::string& code,
-                                           const string16& contents);
+                                           const string16& contents,
+                                           std::string* cld_language = NULL,

[MAD, 2013/05/07 19:49:05]

We don't use default value for function arguments in Chrome.

[hajimehoshi, 2013/05/08 04:06:17]

Done.  Added a test to translate_helper_unittest.cc to check these returned
values.

On 2013/05/07 19:49:05, MAD wrote:

+                                           bool* is_cld_reliable = NULL);
 
   // Returns whether the page associated with |document| is a candidate for
   // translation.  Some pages can explictly specify (via a meta-tag) that they
@@ -118,7 +120,10 @@ class TranslateHelper : public content::RenderViewObserver {
 #if defined(ENABLE_LANGUAGE_DETECTION)
   // Returns the ISO 639_1 language code of the specified |text|, or 'unknown'
   // if it failed.
-  static std::string DetermineTextLanguage(const string16& text);
+  // |is_cld_reliable| is optional. This will be set as true is CLD saids the

[MAD, 2013/05/07 19:49:05]

is CLD saids -> if CLD says.

[hajimehoshi, 2013/05/08 04:06:17]

Done.

+  // detection is reliable, otherwise not.

[MAD, 2013/05/07 19:49:05]

No need for otherwise in comments when it's bool.

[hajimehoshi, 2013/05/08 04:06:17]

Done.

+  static std::string DetermineTextLanguage(const string16& text,
+                                           bool* is_cld_reliable = NULL);

[MAD, 2013/05/07 19:49:05]

Again.

[hajimehoshi, 2013/05/08 04:06:17]

Done.

 #endif
 
   // RenderViewObserver implementation.