chrome/browser/translate/translate_tab_helper.h - Issue 14494004: Added the 'Translation Logs' tab to chrome://translate-internals/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_tab_helper.h

Issue 14494004: Added the 'Translation Logs' tab to chrome://translate-internals/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: first commit Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/translate/translate_manager_browsertest.cc ('k') | chrome/browser/translate/translate_tab_helper.cc » ('j') | chrome/renderer/translate/translate_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_tab_helper.h

diff --git a/chrome/browser/translate/translate_tab_helper.h b/chrome/browser/translate/translate_tab_helper.h

index d2565f4f59e8b4814975fc7941cc598248700729..76c783d2035daba1481c4d42c7dbbd1928e8f241 100644

--- a/chrome/browser/translate/translate_tab_helper.h

+++ b/chrome/browser/translate/translate_tab_helper.h

@@ -10,6 +10,9 @@

#include "content/public/browser/web_contents_observer.h"

#include "content/public/browser/web_contents_user_data.h"

+class GURL;

MAD 2013/05/07 19:49:05 This is not needed. Right?

hajimehoshi 2013/05/08 04:06:17 Right. Thanks. On 2013/05/07 19:49:05, MAD wrote

+struct LanguageDetectionDetails;

class TranslateTabHelper

: public content::WebContentsObserver,

public content::WebContentsUserData<TranslateTabHelper> {

@@ -28,7 +31,7 @@ class TranslateTabHelper

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) OVERRIDE;

- void OnLanguageDetermined(const std::string& language,

+ void OnLanguageDetermined(const LanguageDetectionDetails& details,

bool page_translatable);

void OnPageTranslated(int32 page_id,

const std::string& original_lang,