Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 14472005: Fix dependency tree when using the system ICU. (Closed)

Created:
7 years, 8 months ago by Torne
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix dependency tree when using the system ICU. The combination of generated shim headers, the system ICU targets being type "none", and ui being a static library caused some dependencies to be missed out when use_system_icu==1. Make ui a hard dependency to work around this. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196700

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add proper default for use_system_icu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/common.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
7 years, 8 months ago (2013-04-24 15:01:27 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 8 months ago (2013-04-25 17:19:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/14472005/4001
7 years, 8 months ago (2013-04-26 08:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/14472005/12002
7 years, 8 months ago (2013-04-26 08:57:43 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-26 11:18:18 UTC) #5
Message was sent while issue was closed.
Change committed as 196700

Powered by Google App Engine
This is Rietveld 408576698