Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ui/ui.gyp

Issue 14472005: Fix dependency tree when using the system ICU. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add proper default for use_system_icu Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/ui.gyp
diff --git a/ui/ui.gyp b/ui/ui.gyp
index cb16d09b1bf1aa7f5d402dfb2d24998ebf7d33b3..b2675a3f86a1ca515dc77232a090cf976ae22a45 100644
--- a/ui/ui.gyp
+++ b/ui/ui.gyp
@@ -870,6 +870,12 @@
'<(DEPTH)/webkit/support/setup_third_party.gyp:third_party_headers',
],
}],
+ ['use_system_icu==1', {
+ # When using the system icu, the icu targets generate shim headers
+ # which are included by public headers in the ui target, so we need
+ # ui to be a hard dependency for all its users.
+ 'hard_dependency': 1,
+ }],
],
},
],
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698