src/assembler.h - Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/assembler.h

Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/assembler.h

diff --git a/src/assembler.h b/src/assembler.h

index 381ae0a8015a7f1c02a36e3e2c8f8553eeb4bb45..932376798873ef596bb275edc97f01daa32d92db 100644

--- a/src/assembler.h

+++ b/src/assembler.h

@@ -681,7 +681,7 @@ class ExternalReference BASE_EMBEDDED {

explicit ExternalReference(const SCTableReference& table_ref);

// Isolate::Current() as an external reference.

- static ExternalReference isolate_address();

+ static ExternalReference isolate_address(Isolate* isolate);

// One-of-a-kind references. These references are not part of a general

// pattern. This means that they have to be added to the

« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/assembler.cc » ('j') | no next file with comments »