Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: src/assembler.h

Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/assembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 663 matching lines...) Expand 10 before | Expand all | Expand 10 after
674 ExternalReference(const Debug_Address& debug_address, Isolate* isolate); 674 ExternalReference(const Debug_Address& debug_address, Isolate* isolate);
675 #endif 675 #endif
676 676
677 explicit ExternalReference(StatsCounter* counter); 677 explicit ExternalReference(StatsCounter* counter);
678 678
679 ExternalReference(Isolate::AddressId id, Isolate* isolate); 679 ExternalReference(Isolate::AddressId id, Isolate* isolate);
680 680
681 explicit ExternalReference(const SCTableReference& table_ref); 681 explicit ExternalReference(const SCTableReference& table_ref);
682 682
683 // Isolate::Current() as an external reference. 683 // Isolate::Current() as an external reference.
684 static ExternalReference isolate_address(); 684 static ExternalReference isolate_address(Isolate* isolate);
685 685
686 // One-of-a-kind references. These references are not part of a general 686 // One-of-a-kind references. These references are not part of a general
687 // pattern. This means that they have to be added to the 687 // pattern. This means that they have to be added to the
688 // ExternalReferenceTable in serialize.cc manually. 688 // ExternalReferenceTable in serialize.cc manually.
689 689
690 static ExternalReference incremental_marking_record_write_function( 690 static ExternalReference incremental_marking_record_write_function(
691 Isolate* isolate); 691 Isolate* isolate);
692 static ExternalReference incremental_evacuation_record_write_function( 692 static ExternalReference incremental_evacuation_record_write_function(
693 Isolate* isolate); 693 Isolate* isolate);
694 static ExternalReference store_buffer_overflow_function( 694 static ExternalReference store_buffer_overflow_function(
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
1031 public: 1031 public:
1032 NullCallWrapper() { } 1032 NullCallWrapper() { }
1033 virtual ~NullCallWrapper() { } 1033 virtual ~NullCallWrapper() { }
1034 virtual void BeforeCall(int call_size) const { } 1034 virtual void BeforeCall(int call_size) const { }
1035 virtual void AfterCall() const { } 1035 virtual void AfterCall() const { }
1036 }; 1036 };
1037 1037
1038 } } // namespace v8::internal 1038 } } // namespace v8::internal
1039 1039
1040 #endif // V8_ASSEMBLER_H_ 1040 #endif // V8_ASSEMBLER_H_
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698