src/assembler.cc - Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/assembler.cc

Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/assembler.cc

diff --git a/src/assembler.cc b/src/assembler.cc

index 84d720b248e7efc2e7492881a2be8f6cc43046c9..fff588af3537e2b6cfb4de9d13c91bce4c03617d 100644

--- a/src/assembler.cc

+++ b/src/assembler.cc

@@ -969,8 +969,8 @@ ExternalReference::ExternalReference(const Runtime::Function* f,

: address_(Redirect(isolate, f->entry)) {}

-ExternalReference ExternalReference::isolate_address() {

- return ExternalReference(Isolate::Current());

+ExternalReference ExternalReference::isolate_address(Isolate* isolate) {

+ return ExternalReference(isolate);

}

« no previous file with comments | « src/assembler.h ('k') | src/deoptimizer.h » ('j') | no next file with comments »