Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: src/assembler.cc

Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/assembler.h ('k') | src/deoptimizer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 951 matching lines...) Expand 10 before | Expand all | Expand 10 after
962 ExternalReference::ExternalReference(Runtime::FunctionId id, 962 ExternalReference::ExternalReference(Runtime::FunctionId id,
963 Isolate* isolate) 963 Isolate* isolate)
964 : address_(Redirect(isolate, Runtime::FunctionForId(id)->entry)) {} 964 : address_(Redirect(isolate, Runtime::FunctionForId(id)->entry)) {}
965 965
966 966
967 ExternalReference::ExternalReference(const Runtime::Function* f, 967 ExternalReference::ExternalReference(const Runtime::Function* f,
968 Isolate* isolate) 968 Isolate* isolate)
969 : address_(Redirect(isolate, f->entry)) {} 969 : address_(Redirect(isolate, f->entry)) {}
970 970
971 971
972 ExternalReference ExternalReference::isolate_address() { 972 ExternalReference ExternalReference::isolate_address(Isolate* isolate) {
973 return ExternalReference(Isolate::Current()); 973 return ExternalReference(isolate);
974 } 974 }
975 975
976 976
977 ExternalReference::ExternalReference(const IC_Utility& ic_utility, 977 ExternalReference::ExternalReference(const IC_Utility& ic_utility,
978 Isolate* isolate) 978 Isolate* isolate)
979 : address_(Redirect(isolate, ic_utility.address())) {} 979 : address_(Redirect(isolate, ic_utility.address())) {}
980 980
981 #ifdef ENABLE_DEBUGGER_SUPPORT 981 #ifdef ENABLE_DEBUGGER_SUPPORT
982 ExternalReference::ExternalReference(const Debug_Address& debug_address, 982 ExternalReference::ExternalReference(const Debug_Address& debug_address,
983 Isolate* isolate) 983 Isolate* isolate)
(...skipping 671 matching lines...) Expand 10 before | Expand all | Expand 10 after
1655 assembler_->RecordRelocInfo(RelocInfo::POSITION, state_.current_position); 1655 assembler_->RecordRelocInfo(RelocInfo::POSITION, state_.current_position);
1656 state_.written_position = state_.current_position; 1656 state_.written_position = state_.current_position;
1657 written = true; 1657 written = true;
1658 } 1658 }
1659 1659
1660 // Return whether something was written. 1660 // Return whether something was written.
1661 return written; 1661 return written;
1662 } 1662 }
1663 1663
1664 } } // namespace v8::internal 1664 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/deoptimizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698