Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 14366004: cros: Turn immersive fullscreen on by default (Closed)

Created:
7 years, 8 months ago by James Cook
Modified:
7 years, 8 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

cros: Turn immersive fullscreen on by default Use enabled/disabled flags as this will allow us to turn it off by default after a branch point without changing the strings for about:flags. BUG=233329 TEST=manual, toggle the option in about:flags, by default F4 should enter fullscreen TBR=sky@chromium.org for trivial test expectation change in c/b/ui/browser_browsertest.cc Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195358

Patch Set 1 #

Patch Set 2 : fix linux_chromeos test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -30 lines) Patch
M ash/ash_switches.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
A chrome/browser/ui/ash/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 3 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
James Cook
Peter, PTAL
7 years, 8 months ago (2013-04-18 22:22:47 UTC) #1
pkotwicz
lgtm
7 years, 8 months ago (2013-04-19 16:45:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/14366004/2018
7 years, 8 months ago (2013-04-19 18:39:14 UTC) #3
commit-bot: I haz the power
Presubmit check for 14366004-2018 failed and returned exit status 1. INFO:root:Found 9 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-19 18:39:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/14366004/2018
7 years, 8 months ago (2013-04-19 18:57:11 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-20 01:05:44 UTC) #6
Message was sent while issue was closed.
Change committed as 195358

Powered by Google App Engine
This is Rietveld 408576698