Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc

Issue 14366004: cros: Turn immersive fullscreen on by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix linux_chromeos test expectation Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc
diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc
index 4a5b00543691111ea66e396b252d51c8a7b507b2..87220be5553281476c24e30804586d912edc08bb 100644
--- a/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc
+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc
@@ -17,20 +17,20 @@ namespace chrome {
bool UseImmersiveFullscreen() {
#if defined(OS_CHROMEOS)
+ CommandLine* command = CommandLine::ForCurrentProcess();
// Kiosk mode needs the whole screen.
- CommandLine* command_line = CommandLine::ForCurrentProcess();
- return !command_line->HasSwitch(switches::kKioskMode) &&
- command_line->HasSwitch(ash::switches::kAshImmersiveFullscreen);
+ if (command->HasSwitch(switches::kKioskMode))
+ return false;
+ // Immersive fullscreen is on by default.
+ return !command->HasSwitch(ash::switches::kAshDisableImmersiveFullscreen);
#endif
return false;
}
// Implemented here so all the code dealing with flags lives in one place.
void EnableImmersiveFullscreenForTest() {
-#if defined(OS_CHROMEOS)
- CommandLine* command_line = CommandLine::ForCurrentProcess();
- command_line->AppendSwitch(ash::switches::kAshImmersiveFullscreen);
-#endif
+ // Immersive fullscreen is on by default. If we turn it off, this function
+ // will need to add kAshEnableImmersiveFullscreen to the command line.
}
ImmersiveModeController* CreateImmersiveModeController() {
« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698